From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35403)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1bzebB-0004YE-6X
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 02:55:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1bzeb6-0001K5-Jb
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 02:55:36 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44842)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <thuth@redhat.com>) id 1bzeb6-0001Jb-Dn
	for qemu-devel@nongnu.org; Thu, 27 Oct 2016 02:55:32 -0400
References: <1477508932-5827-1-git-send-email-rth@twiddle.net>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <8a70d138-eccb-1e07-096b-c911fd9562a6@redhat.com>
Date: Thu, 27 Oct 2016 08:55:26 +0200
MIME-Version: 1.0
In-Reply-To: <1477508932-5827-1-git-send-email-rth@twiddle.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] linux-user: Fix s390x safe-syscall for
 z900
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>, Michael Tokarev <mjt@tls.msk.ru>

On 26.10.2016 21:08, Richard Henderson wrote:
> The LT instruction was added in the extended immediate facility
> introduced with the z9-109 processor.
> 
> Cc: Riku Voipio <riku.voipio@iki.fi>
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Fixes: c9bc3437a905b660561a26cd4ecc64579843267b
> Suggested-by: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  linux-user/host/s390x/safe-syscall.inc.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/host/s390x/safe-syscall.inc.S b/linux-user/host/s390x/safe-syscall.inc.S
> index f1b446a..414b44a 100644
> --- a/linux-user/host/s390x/safe-syscall.inc.S
> +++ b/linux-user/host/s390x/safe-syscall.inc.S
> @@ -72,7 +72,7 @@ safe_syscall_base:
>  	 */
>  safe_syscall_start:
>  	/* if signal_pending is non-zero, don't do the call */
> -	lt	%r0,0(%r8)
> +	icm	%r0,15,0(%r8)
>  	jne	2f
>  	svc	0
>  safe_syscall_end:

Reviewed-by: Thomas Huth <thuth@redhat.com>