Re: [RFC PATCH v4 00/44] Add LoongArch LSX instructions

[Richard Henderson <richard.henderson@linaro.org>]

On 4/25/23 08:02, Song Gao wrote:
> Hi,
> 
> This series adds LoongArch LSX instructions, Since the LoongArch
> Vol2 is not open, So we use 'RFC' title.
> 
> I'm not sure when the manual will be open.
> After these patches are reviewed, how about merging them?
> 
> About test:
> V2 we use RISU test the LoongArch LSX instructions.
> 
> QEMU:
>      https://github.com/loongson/qemu/tree/tcg-old-abi-support-lsx
> RISU:
>      https://github.com/loongson/risu/tree/loongarch-suport-lsx
> 
> Build test:
> make docker-test-build@fedora-i386-cross
> 
> The following patches need to be reviewed:
>    0001-target-loongarch-Add-LSX-data-type-VReg.patch
>    0014-target-loongarch-Implement-vmul-vmuh-vmulw-ev-od.patch
>    0030-target-loongarch-Implement-vpcnt.patch
>    0034-target-loongarch-Implement-LSX-fpu-fcvt-instructions.patch
>    0037-target-loongarch-Implement-vbitsel-vset.patch
>    0041-target-loongarch-Implement-vld-vst.patch
> 
> V4:
>    - R-b and rebase;
>    - Migrate the upper half lsx regs;
>    - Remove tcg_gen_mulus2_*;
>    - Vsetallnez use !do_match2;
>    - Use tcg_gen_concat_i64_i128/tcg_gen_extr_i128_i64 to replace
>      TCGV128_LOW(val)/TCGV128_High(val);

One minor nit, everything reviewed!  Congratulations.


r~