Re: [Qemu-devel] [PATCH] checkpatch: g_test_message does not need a a trailing newline

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 21/11/18 19:27, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   scripts/checkpatch.pl | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index eccd656c41..d27bc51f8c 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2802,7 +2802,8 @@ sub process {
>   				info_vreport|
>   				error_report|
>   				warn_report|
> -				info_report}x;
> +				info_report|
> +                                g_test_message}x;

This perl file use <tab> here, shouldn't we keep the same style?

>   
>   	if ($rawline =~ /\b(?:$qemu_error_funcs)\s*\(.*\".*\\n/) {
>   		ERROR("Error messages should not contain newlines\n" . $herecurr);
> 

$ ./scripts/checkpatch.pl -f tests/ipmi-bt-test.c
ERROR: Error messages should not contain newlines
#408: FILE: tests/ipmi-bt-test.c:408:
+        g_test_message("Skipping test for non-x86\n");
total: 1 errors, 0 warnings, 430 lines checked

Nice :)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>