From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57766)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1bmy2p-0001gq-MJ
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 03:03:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1bmy2k-0007AD-O6
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 03:03:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:42297)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1bmy2k-0007A6-I2
	for qemu-devel@nongnu.org; Thu, 22 Sep 2016 03:03:38 -0400
References: <1473750714-48290-1-git-send-email-aik@ozlabs.ru>
	<20160914161724.7d3ad28b@bahia>
	<db0c070f-824f-fd86-8890-4ccbda4c0c5f@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <8aa316a9-f1db-c177-70e2-67a40776689b@redhat.com>
Date: Thu, 22 Sep 2016 15:03:28 +0800
MIME-Version: 1.0
In-Reply-To: <db0c070f-824f-fd86-8890-4ccbda4c0c5f@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Greg Kurz <groug@kaod.org>, Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: qemu-devel@nongnu.org



On 2016=E5=B9=B409=E6=9C=8814=E6=97=A5 23:12, Eric Blake wrote:
> On 09/14/2016 09:17 AM, Greg Kurz wrote:
>> On Tue, 13 Sep 2016 17:11:54 +1000
>> Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>>
>>> The tap backend is already using qemu-bridge-helper to attach tap
>>> interface to a bridge but (unlike the bridge backend) it always uses
>>> the default bridge name - br0.
>>>
>>> This adds a "br" property support to the tap backend.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>> --
>> Cool ! This allows to easily attach to virbr0 :)
>>
>> Now that a consensus seems to have been reached for @br:
> Yes, but there was still my other comment that:
>
>
>>> +++ b/qapi-schema.json
>>> @@ -2575,6 +2575,8 @@
>>>   #
>>>   # @downscript: #optional script to shut down the interface
>>>   #
>>> +# @br: #optional bridge name
> this is missing a '(since 2.8)' designator.  Perhaps the maintainer can
> supply it without needing a v3.
>

Adding "since 2.8" and applied.

Thanks