From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38825)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bue4P-0001Z4-Rj
	for qemu-devel@nongnu.org; Thu, 13 Oct 2016 07:21:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bue4L-0001bO-KY
	for qemu-devel@nongnu.org; Thu, 13 Oct 2016 07:21:04 -0400
References: <1475519097-27611-1-git-send-email-duanj@linux.vnet.ibm.com>
	<1475519097-27611-4-git-send-email-duanj@linux.vnet.ibm.com>
	<60b19618-e725-710f-f512-3f6df471f6f2@linux.vnet.ibm.com>
	<ff68f273-1101-a3ef-f574-3f1e12846787@redhat.com>
	<1b5c6891-1cd2-bf92-0b8b-a0cd9312442f@linux.vnet.ibm.com>
	<1467348300.2794077.1476346928598.JavaMail.zimbra@redhat.com>
	<3e8b8f66-883e-6ea2-c191-6feaf4268110@linux.vnet.ibm.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <8abae521-2b1b-1f77-3e30-c1ec88c2d44e@redhat.com>
Date: Thu, 13 Oct 2016 13:20:52 +0200
MIME-Version: 1.0
In-Reply-To: <3e8b8f66-883e-6ea2-c191-6feaf4268110@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-ppc] [QEMU PATCH v5 3/6] migration: extend
 VMStateInfo
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Halil Pasic <pasic@linux.vnet.ibm.com>, Jianjun Duan <duanj@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, veroniabahaa@gmail.com, peter maydell <peter.maydell@linaro.org>, dgilbert@redhat.com, mst@redhat.com, quintela@redhat.com, mark cave-ayland <mark.cave-ayland@ilande.co.uk>, mdroth@linux.vnet.ibm.com, mreitz@redhat.com, blauwirbel@gmail.com, amit shah <amit.shah@redhat.com>, qemu-ppc@nongnu.org, kraxel@redhat.com, kwolf@redhat.com, dmitry@daynix.com, rth@twiddle.net, leon alrae <leon.alrae@imgtec.com>, aurelien@aurel32.net, david@gibson.dropbear.id.au



On 13/10/2016 12:48, Halil Pasic wrote:
>> >=20
> I'm fine with this. I just think, it would be nice if the contract betw=
een
> the vmstate-core and the client code implementing VMStateInfo callbacks
> could be documented, including when are certain parameters valid, what
> they stand for, and how are they supposed to be used for the next versi=
on of
> the patch. Just to improve readability. Would this be OK with everybody=
?
>=20
> By the way the flag VMS_SINGLE is documented as ignored. Should we drop
> it?

Yes, I think so.

Paolo