public inbox for qemu-devel@nongnu.org
 help / color / mirror / Atom feed
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Eric Blake <eblake@redhat.com>,
	Michael Roth <michael.roth@amd.com>,
	devel@lists.libvirt.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [PATCH-for-11.0] qapi: Remove deprecated SchemaInfoEnumMember::values field
Date: Mon, 23 Mar 2026 20:19:45 -0700	[thread overview]
Message-ID: <8abf41ec-3f8f-4b3c-8966-f9309a404862@linaro.org> (raw)
In-Reply-To: <20260323152124.93051-1-philmd@linaro.org>

On 3/23/26 8:21 AM, Philippe Mathieu-Daudé wrote:
> SchemaInfoEnumMember::values field has been deprecated for
> more than 5 years (see commit 75ecee72625 "qapi: Enable enum
> member introspection to show more than name"), it should be
> safe enough to remove.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   docs/about/deprecated.rst       |  6 ------
>   docs/about/removed-features.rst |  7 +++++++
>   qapi/introspect.json            | 12 +-----------
>   scripts/qapi/introspect.py      |  3 +--
>   4 files changed, 9 insertions(+), 19 deletions(-)
> 

By curiosity, is this patch goal is simply to remove a deprecated 
feature/code, or does it unlock something beyond it?
No judgment here, that's a genuine question, and both are valid reasons!

Looks good to me, to the limit of my qapi knowledge :).
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Regards,
Pierrick


  reply	other threads:[~2026-03-24  3:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-23 15:21 [PATCH-for-11.0] qapi: Remove deprecated SchemaInfoEnumMember::values field Philippe Mathieu-Daudé
2026-03-24  3:19 ` Pierrick Bouvier [this message]
2026-03-24  5:00   ` Philippe Mathieu-Daudé
2026-03-24  7:02     ` Markus Armbruster
2026-03-24  9:15       ` Daniel P. Berrangé
2026-03-24  6:03   ` Peter Krempa
2026-03-24  7:19     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8abf41ec-3f8f-4b3c-8966-f9309a404862@linaro.org \
    --to=pierrick.bouvier@linaro.org \
    --cc=armbru@redhat.com \
    --cc=devel@lists.libvirt.org \
    --cc=eblake@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox