From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
qemu-devel@nongnu.org, qemu-s390x <qemu-s390x@nongnu.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: compile warning in i8259.c
Date: Mon, 15 Mar 2021 17:43:58 +0100 [thread overview]
Message-ID: <8ad75667-9d31-a046-2ed9-a2ea53bb1cde@redhat.com> (raw)
In-Reply-To: <a137ee82-9ef6-dcd9-0b39-6a0257514e78@redhat.com>
On 15/03/21 16:55, Philippe Mathieu-Daudé wrote:
> Since you ask, I'd love to have things solved differently...
> One PIC has 8 IRQs, so we should model 2 cascaded PICs as 2 cascaded
> QOM PICs. But this code is so old and heavily used that my desire
> is unlikely to be realized. And your patch is simpler :>
They are modeled like that, see i8259_init. Perhaps you mean that
pic_read_irq should call itself recursively on the slave PIC if irq == 2
&& s->master?
Paolo
next prev parent reply other threads:[~2021-03-15 16:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 15:14 compile warning in i8259.c Christian Borntraeger
2021-03-15 15:42 ` Thomas Huth
2021-03-15 15:46 ` Christian Borntraeger
2021-03-15 15:50 ` Philippe Mathieu-Daudé
2021-03-15 15:58 ` Thomas Huth
2021-03-15 16:15 ` Christian Borntraeger
2021-03-15 15:44 ` Christian Borntraeger
2021-03-15 15:55 ` Philippe Mathieu-Daudé
2021-03-15 16:43 ` Paolo Bonzini [this message]
2021-03-15 16:20 ` Thomas Huth
2021-03-15 16:27 ` Richard Henderson
2021-03-15 16:27 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ad75667-9d31-a046-2ed9-a2ea53bb1cde@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).