From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Paolo Bonzini" <pbonzini@redhat.com>,
"Cédric Le Goater" <clg@redhat.com>,
qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, Thomas Huth <thuth@redhat.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>
Subject: Re: [PATCH v3] kconfig: Add PCIe devices to s390x machines
Date: Thu, 6 Jul 2023 12:03:45 +0200 [thread overview]
Message-ID: <8ada3ba0-1b09-93aa-a5fb-55ca08c8ef33@linaro.org> (raw)
In-Reply-To: <f45b0555-0808-0e99-24cb-fbf24bc2277e@redhat.com>
On 6/7/23 11:38, Paolo Bonzini wrote:
> On 7/5/23 17:23, Cédric Le Goater wrote:
>> + imply E1000E_PCI_EXPRESS
>> + imply IGB_PCI_EXPRESS
>> + imply USB_XHCI_PCI
>
> "imply" should only be used whenever the device can be created with the
> front-end/back-end combo command line options, and as far as I can see
> this is not the case here.
>
> You could set CONFIG_PCIE_DEVICES=y in s390-softmmu.mak and make these
> three devices "default y if PCI_DEVICES || PCIE_DEVICES".
"default y if PCIE_DEVICES" for *_PCI_EXPRESS.
prev parent reply other threads:[~2023-07-06 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 15:23 [PATCH v3] kconfig: Add PCIe devices to s390x machines Cédric Le Goater
2023-07-05 19:32 ` Matthew Rosato
2023-07-05 20:25 ` Philippe Mathieu-Daudé
2023-07-06 9:38 ` Paolo Bonzini
2023-07-06 10:03 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ada3ba0-1b09-93aa-a5fb-55ca08c8ef33@linaro.org \
--to=philmd@linaro.org \
--cc=borntraeger@linux.ibm.com \
--cc=clg@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).