From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH 2/4] hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header
Date: Thu, 14 Dec 2023 17:42:59 +0100 [thread overview]
Message-ID: <8ada8156-ebd3-491e-b387-574ca06ec0dc@redhat.com> (raw)
In-Reply-To: <20231212113640.30287-3-philmd@linaro.org>
On 12/12/2023 12.36, Philippe Mathieu-Daudé wrote:
> mips_itu.c only requires declarations from "hw/core/cpu.h"
> and "cpu.h". Avoid including the huge "exec/exec-all.h" header.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/misc/mips_itu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/misc/mips_itu.c b/hw/misc/mips_itu.c
> index 5a83ccc4e8..37aea0e737 100644
> --- a/hw/misc/mips_itu.c
> +++ b/hw/misc/mips_itu.c
> @@ -22,9 +22,10 @@
> #include "qemu/log.h"
> #include "qemu/module.h"
> #include "qapi/error.h"
> -#include "exec/exec-all.h"
> +#include "hw/core/cpu.h"
> #include "hw/misc/mips_itu.h"
> #include "hw/qdev-properties.h"
> +#include "target/mips/cpu.h"
>
> #define ITC_TAG_ADDRSPACE_SZ (ITC_ADDRESSMAP_NUM * 8)
> /* Initialize as 4kB area to fit all 32 cells with default 128B grain.
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-12-14 16:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 11:36 [PATCH 0/4] hw: Remove 'exec/exec-all.h' header when unused Philippe Mathieu-Daudé
2023-12-12 11:36 ` [PATCH 1/4] hw/ppc/spapr_hcall: Remove unused 'exec/exec-all.h' included header Philippe Mathieu-Daudé
2023-12-14 16:42 ` Thomas Huth
2023-12-14 17:50 ` Richard Henderson
2023-12-12 11:36 ` [PATCH 2/4] hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header Philippe Mathieu-Daudé
2023-12-14 16:42 ` Thomas Huth [this message]
2023-12-12 11:36 ` [PATCH 3/4] hw/s390x/ipl: Remove unused 'exec/exec-all.h' included header Philippe Mathieu-Daudé
2023-12-12 13:08 ` Christian Borntraeger
2023-12-12 15:28 ` Eric Farman
2023-12-13 8:18 ` Christian Borntraeger
2023-12-26 16:08 ` Philippe Mathieu-Daudé
2023-12-14 16:21 ` Eric Farman
2023-12-12 11:36 ` [PATCH 4/4] target: Restrict 'sysemu/reset.h' to system emulation Philippe Mathieu-Daudé
2023-12-14 16:43 ` Thomas Huth
2023-12-15 8:31 ` Zhao Liu
2023-12-26 16:08 ` [PATCH 0/4] hw: Remove 'exec/exec-all.h' header when unused Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ada8156-ebd3-491e-b387-574ca06ec0dc@redhat.com \
--to=thuth@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).