From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38912)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bXyVR-0000dO-Ia
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 18:31:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1bXyVQ-0006bz-LQ
	for qemu-devel@nongnu.org; Thu, 11 Aug 2016 18:31:17 -0400
Sender: Richard Henderson <rth7680@gmail.com>
References: <1470855666-31696-1-git-send-email-nikunj@linux.vnet.ibm.com>
	<1470855666-31696-3-git-send-email-nikunj@linux.vnet.ibm.com>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <8b29396a-a639-afb2-4f39-62ac9fdf9fab@twiddle.net>
Date: Thu, 11 Aug 2016 23:31:13 +0100
MIME-Version: 1.0
In-Reply-To: <1470855666-31696-3-git-send-email-nikunj@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v1 02/10] target-ppc: consolidate load
 operations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Cc: qemu-devel@nongnu.org, benh@kernel.crashing.org

On 08/10/2016 08:00 PM, Nikunj A Dadhania wrote:
> +#define GEN_QEMU_LOAD_64(ldop, op)                                  \
> +static void glue(gen_qemu_, glue(ldop, _i64))(DisasContext *ctx,    \
> +                                             TCGv_i64 val,          \
> +                                             TCGv addr)             \
> +{                                                                   \
> +    tcg_gen_qemu_ld_i64(val, addr, ctx->mem_idx,                    \
> +                        op | ctx->default_tcg_memop_mask);          \
> +}
> +
> +GEN_QEMU_LOAD_64(ld32u, MO_UL)
> +GEN_QEMU_LOAD_64(ld32s, MO_SL)
>
>  static inline void gen_qemu_ld64(DisasContext *ctx, TCGv_i64 arg1, TCGv arg2)
>  {

You can of course include this last function in the cleanup as well.


r~