* [PATCH] target/mips: Fix FTRUNC_S and FTRUNC_U trans helper
@ 2022-05-03 14:42 nihui
2022-05-03 15:24 ` Richard Henderson
2022-05-30 14:21 ` Philippe Mathieu-Daudé via
0 siblings, 2 replies; 3+ messages in thread
From: nihui @ 2022-05-03 14:42 UTC (permalink / raw)
To: qemu-devel; +Cc: nihui
Fix the FTRUNC_S and FTRUNC_U trans helper problem.
Signed-off-by: nihui <shuizhuyuanluo@126.com>
---
target/mips/tcg/msa_translate.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c
index 0b3dd0957c..1bcdbb1121 100644
--- a/target/mips/tcg/msa_translate.c
+++ b/target/mips/tcg/msa_translate.c
@@ -752,8 +752,8 @@ static bool trans_msa_2rf(DisasContext *ctx, arg_msa_r *a,
}
TRANS(FCLASS, trans_msa_2rf, gen_helper_msa_fclass_df);
-TRANS(FTRUNC_S, trans_msa_2rf, gen_helper_msa_fclass_df);
-TRANS(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_s_df);
+TRANS(FTRUNC_S, trans_msa_2rf, gen_helper_msa_ftrunc_s_df);
+TRANS(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_u_df);
TRANS(FSQRT, trans_msa_2rf, gen_helper_msa_fsqrt_df);
TRANS(FRSQRT, trans_msa_2rf, gen_helper_msa_frsqrt_df);
TRANS(FRCP, trans_msa_2rf, gen_helper_msa_frcp_df);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] target/mips: Fix FTRUNC_S and FTRUNC_U trans helper
2022-05-03 14:42 [PATCH] target/mips: Fix FTRUNC_S and FTRUNC_U trans helper nihui
@ 2022-05-03 15:24 ` Richard Henderson
2022-05-30 14:21 ` Philippe Mathieu-Daudé via
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2022-05-03 15:24 UTC (permalink / raw)
To: nihui, qemu-devel, Philippe Mathieu-Daudé
On 5/3/22 07:42, nihui wrote:
> Fix the FTRUNC_S and FTRUNC_U trans helper problem.
>
> Signed-off-by: nihui <shuizhuyuanluo@126.com>
> ---
> target/mips/tcg/msa_translate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c
> index 0b3dd0957c..1bcdbb1121 100644
> --- a/target/mips/tcg/msa_translate.c
> +++ b/target/mips/tcg/msa_translate.c
> @@ -752,8 +752,8 @@ static bool trans_msa_2rf(DisasContext *ctx, arg_msa_r *a,
> }
>
> TRANS(FCLASS, trans_msa_2rf, gen_helper_msa_fclass_df);
> -TRANS(FTRUNC_S, trans_msa_2rf, gen_helper_msa_fclass_df);
> -TRANS(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_s_df);
> +TRANS(FTRUNC_S, trans_msa_2rf, gen_helper_msa_ftrunc_s_df);
> +TRANS(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_u_df);
> TRANS(FSQRT, trans_msa_2rf, gen_helper_msa_fsqrt_df);
> TRANS(FRSQRT, trans_msa_2rf, gen_helper_msa_frsqrt_df);
> TRANS(FRCP, trans_msa_2rf, gen_helper_msa_frcp_df);
Cc: phil
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] target/mips: Fix FTRUNC_S and FTRUNC_U trans helper
2022-05-03 14:42 [PATCH] target/mips: Fix FTRUNC_S and FTRUNC_U trans helper nihui
2022-05-03 15:24 ` Richard Henderson
@ 2022-05-30 14:21 ` Philippe Mathieu-Daudé via
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-05-30 14:21 UTC (permalink / raw)
To: nihui, qemu-devel
On 3/5/22 16:42, nihui wrote:
> Fix the FTRUNC_S and FTRUNC_U trans helper problem.
>
> Signed-off-by: nihui <shuizhuyuanluo@126.com>
> ---
> target/mips/tcg/msa_translate.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/mips/tcg/msa_translate.c b/target/mips/tcg/msa_translate.c
> index 0b3dd0957c..1bcdbb1121 100644
> --- a/target/mips/tcg/msa_translate.c
> +++ b/target/mips/tcg/msa_translate.c
> @@ -752,8 +752,8 @@ static bool trans_msa_2rf(DisasContext *ctx, arg_msa_r *a,
> }
>
> TRANS(FCLASS, trans_msa_2rf, gen_helper_msa_fclass_df);
> -TRANS(FTRUNC_S, trans_msa_2rf, gen_helper_msa_fclass_df);
> -TRANS(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_s_df);
> +TRANS(FTRUNC_S, trans_msa_2rf, gen_helper_msa_ftrunc_s_df);
> +TRANS(FTRUNC_U, trans_msa_2rf, gen_helper_msa_ftrunc_u_df);
> TRANS(FSQRT, trans_msa_2rf, gen_helper_msa_fsqrt_df);
> TRANS(FRSQRT, trans_msa_2rf, gen_helper_msa_frsqrt_df);
> TRANS(FRCP, trans_msa_2rf, gen_helper_msa_frcp_df);
Fixes: 5c5b64000c ("target/mips: Convert MSA 2RF instruction format to
decodetree")
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Queued.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-30 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-03 14:42 [PATCH] target/mips: Fix FTRUNC_S and FTRUNC_U trans helper nihui
2022-05-03 15:24 ` Richard Henderson
2022-05-30 14:21 ` Philippe Mathieu-Daudé via
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).