From: Richard Henderson <richard.henderson@linaro.org>
To: David Gibson <david@gibson.dropbear.id.au>, peter.maydell@linaro.org
Cc: i.mitsyanko@gmail.com, qemu-arm@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCHv3] exynos4210_gic: Suppress gcc9 format-truncation warnings
Date: Mon, 2 Dec 2019 08:08:00 -0800 [thread overview]
Message-ID: <8b490fbe-2b09-2a2c-16a8-6739ce6a847d@linaro.org> (raw)
In-Reply-To: <20191202060806.77968-1-david@gibson.dropbear.id.au>
On 12/1/19 6:08 AM, David Gibson wrote:
>
> - for (i = 0; i < s->num_cpu; i++) {
> + /*
> + * This clues in gcc that our on-stack buffers do, in fact have
> + * enough room for the cpu numbers. gcc 9.2.1 on 32-bit x86
> + * doesn't figure this out, otherwise and gives spurious warnings.
> + */
> + assert(n <= EXYNOS4210_NCPUS);
> + for (i = 0; i < n; i++) {
> +
> /* Map CPU interface per SMP Core */
Watch out for the extra line added at the start of the block. Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-12-02 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 6:08 [PATCHv3] exynos4210_gic: Suppress gcc9 format-truncation warnings David Gibson
2019-12-02 16:08 ` Richard Henderson [this message]
2019-12-02 17:44 ` Peter Maydell
2019-12-03 0:21 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b490fbe-2b09-2a2c-16a8-6739ce6a847d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=i.mitsyanko@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).