From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Michael Roth" <mdroth@linux.vnet.ibm.com>,
qemu-block@nongnu.org, "Paul Durrant" <paul@xen.org>,
"Laszlo Ersek" <lersek@redhat.com>,
"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Greg Kurz" <groug@kaod.org>,
armbru@redhat.com, "Gerd Hoffmann" <kraxel@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org, "Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp
Date: Fri, 6 Mar 2020 06:43:43 -0600 [thread overview]
Message-ID: <8b4ef7d1-f1dd-91f3-0c34-787818cbecd1@redhat.com> (raw)
In-Reply-To: <20200306051536.27803-3-vsementsov@virtuozzo.com>
On 3/5/20 11:15 PM, Vladimir Sementsov-Ogievskiy wrote:
> Script adds ERRP_AUTO_PROPAGATE macro invocation where appropriate and
> does corresponding changes in code (look for details in
> include/qapi/error.h)
>
> Usage example:
> spatch --sp-file scripts/coccinelle/auto-propagated-errp.cocci \
> --macro-file scripts/cocci-macro-file.h --in-place --no-show-diff \
> blockdev-nbd.c qemu-nbd.c {block/nbd*,nbd/*,include/block/nbd*}.[hc]
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>
I'll let Markus do the final review of this, but my personal take is
that if the subsequent patches created by using this script are
reasonable, then this script was good enough.
> +// Always use the same patter for checking error
pattern
> +@@
> +identifier rule1.fn;
> +symbol errp;
> +@@
> +
> + fn(...)
> + {
> + <...
> +- *errp != NULL
> ++ *errp
> + ...>
> + }
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-03-06 12:44 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 5:15 [PATCH v8 00/10] error: auto propagated local_err part I Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 01/10] error: auto propagated local_err Vladimir Sementsov-Ogievskiy
2020-03-06 8:55 ` Paul Durrant
2020-03-06 10:28 ` Greg Kurz
2020-03-06 11:02 ` Alberto Garcia
2020-03-06 12:37 ` Eric Blake
2020-03-06 13:00 ` Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 02/10] scripts: add coccinelle script to use auto propagated errp Vladimir Sementsov-Ogievskiy
2020-03-06 12:43 ` Eric Blake [this message]
2020-03-08 19:09 ` Christian Schoenebeck
2020-03-10 6:47 ` Vladimir Sementsov-Ogievskiy
2020-03-09 9:56 ` Markus Armbruster
2020-03-10 7:44 ` Vladimir Sementsov-Ogievskiy
2020-03-10 15:47 ` Markus Armbruster
2020-03-11 6:55 ` Vladimir Sementsov-Ogievskiy
2020-03-11 8:32 ` Vladimir Sementsov-Ogievskiy
2020-03-11 9:04 ` Markus Armbruster
2020-03-11 9:16 ` Vladimir Sementsov-Ogievskiy
2020-03-11 8:29 ` Vladimir Sementsov-Ogievskiy
2020-03-11 9:38 ` Markus Armbruster
2020-03-11 14:05 ` Vladimir Sementsov-Ogievskiy
2020-03-11 14:41 ` Markus Armbruster
2020-03-11 14:46 ` Vladimir Sementsov-Ogievskiy
2020-03-12 7:23 ` Markus Armbruster
2020-03-12 7:42 ` Vladimir Sementsov-Ogievskiy
2020-03-11 8:35 ` Vladimir Sementsov-Ogievskiy
2020-03-11 9:33 ` Markus Armbruster
2020-03-11 9:49 ` Vladimir Sementsov-Ogievskiy
2020-03-11 9:53 ` Markus Armbruster
2020-03-11 10:11 ` Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 03/10] hw/sd/ssi-sd: fix error handling in ssi_sd_realize Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 04/10] SD (Secure Card): introduce ERRP_AUTO_PROPAGATE Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 05/10] pflash: " Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 06/10] fw_cfg: " Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 07/10] virtio-9p: " Vladimir Sementsov-Ogievskiy
2020-03-08 18:55 ` Christian Schoenebeck
2020-03-06 5:15 ` [PATCH v8 08/10] TPM: " Vladimir Sementsov-Ogievskiy
2020-03-06 5:15 ` [PATCH v8 09/10] nbd: " Vladimir Sementsov-Ogievskiy
2020-03-06 12:45 ` Eric Blake
2020-03-06 5:15 ` [PATCH v8 10/10] xen: " Vladimir Sementsov-Ogievskiy
2020-03-06 9:12 ` Paul Durrant
2020-03-06 9:18 ` Vladimir Sementsov-Ogievskiy
2020-03-06 15:21 ` [PATCH v8 00/10] error: auto propagated local_err part I Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b4ef7d1-f1dd-91f3-0c34-787818cbecd1@redhat.com \
--to=eblake@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=armbru@redhat.com \
--cc=groug@kaod.org \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mreitz@redhat.com \
--cc=paul@xen.org \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=sstabellini@kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).