qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: yuri.benditovich@daynix.com, andrew@daynix.com
Subject: Re: [PATCH] ebpf: only include in system emulators
Date: Wed, 8 Sep 2021 11:08:52 +0800	[thread overview]
Message-ID: <8b500aeb-b4e2-dcee-24f8-825ae6327acf@redhat.com> (raw)
In-Reply-To: <20210907104512.129103-1-pbonzini@redhat.com>


在 2021/9/7 下午6:45, Paolo Bonzini 写道:
> eBPF files are being included in system emulators, which is useless


I think it should work since it's an independent feature. The current 
use case is to offload the RSS from Qemu to kernel TAP.


>   and
> also breaks compilation because ebpf/trace-events is only processed
> if a system emulator is included in the build.


Andrew, any way to fix this?

Thanks


>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/566
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   ebpf/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ebpf/meson.build b/ebpf/meson.build
> index 9cd0635370..2dd0fd8948 100644
> --- a/ebpf/meson.build
> +++ b/ebpf/meson.build
> @@ -1 +1 @@
> -common_ss.add(when: libbpf, if_true: files('ebpf_rss.c'), if_false: files('ebpf_rss-stub.c'))
> +softmmu_ss.add(when: libbpf, if_true: files('ebpf_rss.c'), if_false: files('ebpf_rss-stub.c'))



  parent reply	other threads:[~2021-09-08  3:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 10:45 [PATCH] ebpf: only include in system emulators Paolo Bonzini
2021-09-07 10:58 ` Philippe Mathieu-Daudé
2021-09-07 11:05 ` Peter Maydell
2021-09-08  3:08 ` Jason Wang [this message]
2021-09-08  5:46   ` Paolo Bonzini
2021-09-09  3:07     ` Jason Wang
2021-09-09  9:49       ` Peter Maydell
2021-09-09  9:51         ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b500aeb-b4e2-dcee-24f8-825ae6327acf@redhat.com \
    --to=jasowang@redhat.com \
    --cc=andrew@daynix.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).