From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22609CA9EB6 for ; Wed, 23 Oct 2019 14:48:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA9FC2086D for ; Wed, 23 Oct 2019 14:48:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA9FC2086D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNHvd-0006CC-Lc for qemu-devel@archiver.kernel.org; Wed, 23 Oct 2019 10:48:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59978) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iNHtX-0004Rd-2L for qemu-devel@nongnu.org; Wed, 23 Oct 2019 10:45:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iNHtV-0000Jw-VY for qemu-devel@nongnu.org; Wed, 23 Oct 2019 10:45:51 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:60887) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iNHt2-0008Kf-Bt; Wed, 23 Oct 2019 10:45:40 -0400 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MgNlH-1hnyGI3P9b-00hu3x; Wed, 23 Oct 2019 16:45:09 +0200 Subject: Re: [PATCH 3/3] qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms To: Eric Blake , Frediano Ziglio References: <20191023122652.2999-1-fziglio@redhat.com> <20191023122652.2999-3-fziglio@redhat.com> <5f20705e-60bc-08d5-8b6e-72438afabefe@vivier.eu> <1860840671.8198083.1571840126307.JavaMail.zimbra@redhat.com> <21fd3aa0-232c-06e8-1e20-b5c98f125468@redhat.com> From: Laurent Vivier Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: <8b52c02c-1e26-4ac7-3f79-db4459f9c178@vivier.eu> Date: Wed, 23 Oct 2019 16:45:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <21fd3aa0-232c-06e8-1e20-b5c98f125468@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:yaOJPgl7oFy0xUmi7sFeukwyBRLcZ6LZCrNtFSzugpvKAnK7oYn UGC+ZZvb5W0IRIqyieLCs61bJ928Nkx+toyYyPCEzHUQwpJr6fXSmktuW5uDoODxiaorfAH 78F3hGef/Vq9hv56OiuPPDrl+15oHPV0SkiUlO7IiRGfk02g/7EYWPbdSnqV6++eEyHCgyE cSCivnvDAvFhjS87tmpqg== X-UI-Out-Filterresults: notjunk:1;V03:K0:u9fa8MSPNq8=:1gFildFXe1i/H+gjCDDBJp rg2iqnC53wcPggPaQB+1elUQJTuAyog6XZ4doh6d0TP5wXnXvZcKeF7taHh8CgUP/QpXHjLp4 i7MnCDGDJeHpEf1x65jSxA2dH7fZ0bzrfN1aDZwfucsWZDbR960ZP/y7CtSdniG2LazD+6Soi D33+X9Z8iTxAv9j7r5D99meekntsh2C6hkSI0LQUvkezHn95CWEIw7uNaw8YMZSy0JF1LuIat IU/wAukDWBMuLBLiY2RRWIMuXbcF5Z1m+VbXNf6PxFR8OqmtsX2UFqslASc0zaEGnaG3u8OA6 6yDaAgluHzvzaVyE8ES1iIxA5/gwiCYI9+MlxkUVb6pVaZcoW6cKDTOYs6FQpl8sShiYn4wOL SxQal6u3E5o6gy6opemm7ZBxUiqgw4ku7PRW8rMSsrGN0Sjn7lj8JBxxiNkaISH4MCR2aAsIn P9z8jfXYD2tM3KCveDv8LJRrvhp7nhiTLnoOEhDpnJ46VTU26dH116gcYu0AEOhaeBrZOGCxm GKgwcCNdKctWBKUtoJ/csBmplHvkudc+Nj6YhvliousyiJ5uN3toJ7DOSjVQFRBntjjRDxu4h m9Gpv2IV8MdUfTOWNi1gyWfpW7OwEu6DdW9hQNoG5PRqYWMp1JdRRtbu33XYzHvkg4u2OE0j+ XOTxvwirU+l3wM4zH8N6D18iz/KD2FubJ/H2BswcxfKCIv/DFLiJTlUSAkezhhdzuPCEFt8B8 5Wl5sN2yEK9a0qsuF3AKjyc8gxqd1/pAN55trLRPh0LFh/ED7X7Wg2H0OJPBCO4vXG+JupyPF Y/nxSpTXBWtKBgeeb5QFCybQfQU5tSgWqMDkJlRpucVoHMQHKrGFtncGChrMKiJJ9q+1Y4X1X I14anmu39AcKUSgVCJtTqalPXuV4O4f2QmWuYQjGU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.130 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Michael Tokarev , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 23/10/2019 à 16:23, Eric Blake a écrit : > On 10/23/19 9:15 AM, Frediano Ziglio wrote: >>> >>> On 10/23/19 8:42 AM, Laurent Vivier wrote: >>>> Le 23/10/2019 à 14:26, Frediano Ziglio a écrit : >>>>> Signed-off-by: Frediano Ziglio >>>>> --- >>>>>    util/qemu-timer.c | 6 +----- >>>>>    1 file changed, 1 insertion(+), 5 deletions(-) >>>>> >>>>> diff --git a/util/qemu-timer.c b/util/qemu-timer.c >>>>> index d428fec567..094a20a05a 100644 >>>>> --- a/util/qemu-timer.c >>>>> +++ b/util/qemu-timer.c >>>>> @@ -322,11 +322,7 @@ int qemu_timeout_ns_to_ms(int64_t ns) >>>>>        ms = DIV_ROUND_UP(ns, SCALE_MS); >>>>>           /* To avoid overflow problems, limit this to 2^31, i.e. >>>>> approx 25 >>>>>        days */ >>>>> -    if (ms > (int64_t) INT32_MAX) { >>>>> -        ms = INT32_MAX; >>>>> -    } >>>>> - >>>>> -    return (int) ms; >>>>> +    return (int) MIN(ms, (int64_t) INT32_MAX); >>>>>    } >>> >>> Why so many casts?  It should also work as: >>> >>> return MIN(ms, INT32_MAX); >>> >> >> This was former version. Laurent pointed out that MIN macro >> is using ternary operator which is expected to find the same time >> on second and third part so the cast inside the MIN macro. >> The cast before MIN was kept from previous code. > > The C rules for ternary type promotion guarantee that the MIN macro > produces the correct type without the cast ('cond ? int64_t : int32_t' > produces int64_t). gdb seems to disagree with that: (gdb) whatis l type = long long (gdb) whatis i type = int (gdb) whatis 1 ? l : i type = long long (gdb) whatis 0 ? l : i type = int It's on what I based my previous comment. But both approaches are correct in the end. Thanks, Laurent