Re: [Qemu-devel] [PATCH 1/6] tests/tcg/test_path.c: include utils/bufferiszero.c

[Cleber Rosa <crosa@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]


On 08/02/2017 06:24 PM, Cleber Rosa wrote:
> 
> 
> On 08/02/2017 05:36 PM, Philippe Mathieu-Daudé wrote:
>> Hi Cleber,
>>
>> On 08/02/2017 05:15 PM, Cleber Rosa wrote:
>>> Which contains one specific function used by iov.c.
>>>
>>> Without this, "make -C tests/tcg test_path" (and consequently
>>> "make -C tests/tcg" or simply "make test") fails quite early.
>>>
>>> Signed-off-by: Cleber Rosa <crosa@redhat.com>
>>> ---
>>>   tests/tcg/test_path.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tests/tcg/test_path.c b/tests/tcg/test_path.c
>>> index 1c29bce..74dbdaf 100644
>>> --- a/tests/tcg/test_path.c
>>> +++ b/tests/tcg/test_path.c
>>> @@ -3,6 +3,7 @@
>>>   #include "util/cutils.c"
>>>   #include "util/hexdump.c"
>>>   #include "util/iov.c"
>>> +#include "util/bufferiszero.c"
>>
>> This fixes the build, however why not take this opportunity to fix it
>> through the Makefile instead of including .c?
>>
> 
> Do you mean for all of the .c includes?  I just took a baby step, which
> seemed more consistent with the mission (get it to build), without
> changing a lot.
> 

Hi Phil,

Can you clarify what you meant here?

Thanks!

-- 
Cleber Rosa
[ Sr Software Engineer - Virtualization Team - Red Hat ]
[ Avocado Test Framework - avocado-framework.github.io ]
[  7ABB 96EB 8B46 B94D 5E0F  E9BB 657E 8D33 A5F2 09F3  ]


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]