From: Thomas Huth <thuth@redhat.com>
To: Su Hang <suhang16@mails.ucas.ac.cn>, stefanha@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] util/uri.c formating
Date: Tue, 20 Feb 2018 09:39:14 +0100 [thread overview]
Message-ID: <8b672808-03a4-d5d8-d852-7c4e01ef6e6c@redhat.com> (raw)
In-Reply-To: <1519113760-4474-1-git-send-email-suhang16@mails.ucas.ac.cn>
On 20.02.2018 09:02, Su Hang wrote:
> Formating the code with `clang-format -i util/uri.c`.
> My .clang-format file content is:
> '''
> IndentWidth: 4
> BreakBeforeBraces: Linux
> '''
>
> Then use `perl -pi -e "s/return \((.*?)\);/return \1;/g" util/uri.c`
> to remove pattern like this: "return (1);"
The patch does not apply on git master ... did you do this on top of
your previous patch? If so, please create a patch against the git master
branch instead.
> checkpatch.pl still rise these two kinds of "ERROR", I'm not sure
> whether I should also suppress these, so I left it.
I think it's OK if you ignore those errors for now.
Thomas
next prev parent reply other threads:[~2018-02-20 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 8:02 [Qemu-devel] [PATCH v2] util/uri.c formating Su Hang
2018-02-20 8:39 ` Thomas Huth [this message]
2018-02-20 9:14 ` Peter Maydell
2018-02-20 9:28 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b672808-03a4-d5d8-d852-7c4e01ef6e6c@redhat.com \
--to=thuth@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=suhang16@mails.ucas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).