* [PATCH] error: Strip trailing '\n' from an error string argument
@ 2025-03-12 14:35 Markus Armbruster
2025-03-12 14:50 ` Peter Maydell
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Markus Armbruster @ 2025-03-12 14:35 UTC (permalink / raw)
To: qemu-devel; +Cc: gaosong, vladislav.yaroshchuk
Tracked down with scripts/coccinelle/err-bad-newline.cocci.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
net/vmnet-common.m | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/vmnet-common.m b/net/vmnet-common.m
index 54d900ba67..ab33ce2b0c 100644
--- a/net/vmnet-common.m
+++ b/net/vmnet-common.m
@@ -94,7 +94,7 @@ ssize_t vmnet_receive_common(NetClientState *nc,
if_status = vmnet_write(s->vmnet_if, &packet, &pkt_cnt);
if (if_status != VMNET_SUCCESS) {
- error_report("vmnet: write error: %s\n",
+ error_report("vmnet: write error: %s",
vmnet_status_map_str(if_status));
return -1;
}
--
2.48.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] error: Strip trailing '\n' from an error string argument
2025-03-12 14:35 [PATCH] error: Strip trailing '\n' from an error string argument Markus Armbruster
@ 2025-03-12 14:50 ` Peter Maydell
2025-03-12 19:08 ` Philippe Mathieu-Daudé
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2025-03-12 14:50 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, gaosong, vladislav.yaroshchuk
On Wed, 12 Mar 2025 at 14:35, Markus Armbruster <armbru@redhat.com> wrote:
>
> Tracked down with scripts/coccinelle/err-bad-newline.cocci.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> net/vmnet-common.m | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/vmnet-common.m b/net/vmnet-common.m
> index 54d900ba67..ab33ce2b0c 100644
> --- a/net/vmnet-common.m
> +++ b/net/vmnet-common.m
> @@ -94,7 +94,7 @@ ssize_t vmnet_receive_common(NetClientState *nc,
>
> if_status = vmnet_write(s->vmnet_if, &packet, &pkt_cnt);
> if (if_status != VMNET_SUCCESS) {
> - error_report("vmnet: write error: %s\n",
> + error_report("vmnet: write error: %s",
> vmnet_status_map_str(if_status));
> return -1;
> }
> --
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] error: Strip trailing '\n' from an error string argument
2025-03-12 14:35 [PATCH] error: Strip trailing '\n' from an error string argument Markus Armbruster
2025-03-12 14:50 ` Peter Maydell
@ 2025-03-12 19:08 ` Philippe Mathieu-Daudé
2025-03-13 9:03 ` gaosong
2025-03-19 8:37 ` Markus Armbruster
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-03-12 19:08 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: gaosong, vladislav.yaroshchuk
On 12/3/25 15:35, Markus Armbruster wrote:
> Tracked down with scripts/coccinelle/err-bad-newline.cocci.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> net/vmnet-common.m | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] error: Strip trailing '\n' from an error string argument
2025-03-12 14:35 [PATCH] error: Strip trailing '\n' from an error string argument Markus Armbruster
2025-03-12 14:50 ` Peter Maydell
2025-03-12 19:08 ` Philippe Mathieu-Daudé
@ 2025-03-13 9:03 ` gaosong
2025-03-19 8:37 ` Markus Armbruster
3 siblings, 0 replies; 5+ messages in thread
From: gaosong @ 2025-03-13 9:03 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: vladislav.yaroshchuk
在 2025/3/12 下午10:35, Markus Armbruster 写道:
> Tracked down with scripts/coccinelle/err-bad-newline.cocci.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> net/vmnet-common.m | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Song Gao <gaosong@loongson.cn>
Thanks.
Song Gao
> diff --git a/net/vmnet-common.m b/net/vmnet-common.m
> index 54d900ba67..ab33ce2b0c 100644
> --- a/net/vmnet-common.m
> +++ b/net/vmnet-common.m
> @@ -94,7 +94,7 @@ ssize_t vmnet_receive_common(NetClientState *nc,
>
> if_status = vmnet_write(s->vmnet_if, &packet, &pkt_cnt);
> if (if_status != VMNET_SUCCESS) {
> - error_report("vmnet: write error: %s\n",
> + error_report("vmnet: write error: %s",
> vmnet_status_map_str(if_status));
> return -1;
> }
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] error: Strip trailing '\n' from an error string argument
2025-03-12 14:35 [PATCH] error: Strip trailing '\n' from an error string argument Markus Armbruster
` (2 preceding siblings ...)
2025-03-13 9:03 ` gaosong
@ 2025-03-19 8:37 ` Markus Armbruster
3 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2025-03-19 8:37 UTC (permalink / raw)
To: qemu-devel
Cc: gaosong, vladislav.yaroshchuk, Peter Maydell,
Philippe Mathieu-Daudé
Queued for 10.0.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-03-19 8:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-12 14:35 [PATCH] error: Strip trailing '\n' from an error string argument Markus Armbruster
2025-03-12 14:50 ` Peter Maydell
2025-03-12 19:08 ` Philippe Mathieu-Daudé
2025-03-13 9:03 ` gaosong
2025-03-19 8:37 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).