From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/arm/translate.c: Delete/amend incorrect comments
Date: Mon, 3 Aug 2020 20:54:43 -0700 [thread overview]
Message-ID: <8b6b5af5-1e95-c4c5-ec28-027335ef359f@linaro.org> (raw)
In-Reply-To: <20200803132815.3861-1-peter.maydell@linaro.org>
On 8/3/20 6:28 AM, Peter Maydell wrote:
> In arm_tr_init_disas_context() we have a FIXME comment that suggests
> "cpu_M0 can probably be the same as cpu_V0". This isn't in fact
> possible: cpu_V0 is used as a temporary inside gen_iwmmxt_shift(),
> and that function is called in various places where cpu_M0 contains a
> live value (i.e. between gen_op_iwmmxt_movq_M0_wRn() and
> gen_op_iwmmxt_movq_wRn_M0() calls). Remove the comment.
>
> We also have a comment on the declarations of cpu_V0/V1/M0 which
> claims they're "for efficiency". This isn't true with modern TCG, so
> replace this comment with one which notes that they're only used with
> the iwmmxt decode.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2020-08-04 3:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 13:28 [PATCH] target/arm/translate.c: Delete/amend incorrect comments Peter Maydell
2020-08-04 3:54 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b6b5af5-1e95-c4c5-ec28-027335ef359f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).