From: Rorie Reyes <rreyes@linux.ibm.com>
To: Anthony Krowiak <akrowiak@linux.ibm.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org
Cc: pbonzini@redhat.com, cohuck@redhat.com, pasic@linux.ibm.com,
jjherne@linux.ibm.com, borntraeger@linux.ibm.com,
alex.williamson@redhat.com, clg@redhat.com, thuth@redhat.com
Subject: Re: [RFC PATCH v12 2/4] hw/vfio/ap: store object indicating AP config changed in a queue
Date: Mon, 9 Jun 2025 10:00:26 -0400 [thread overview]
Message-ID: <8b806b24-62fe-4769-80fc-f6afe479e455@linux.ibm.com> (raw)
In-Reply-To: <fb9f5bf3-68d4-4a2f-9f8a-e781e5059475@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
On 6/9/25 6:19 AM, Anthony Krowiak wrote:
>> + QTAILQ_INSERT_TAIL(&cfg_chg_events, cfg_chg_event, next);
>
> Need locking here:
>
> WITH_QEMU_LOCK_GUARD(&cfg_chg_events_lock) {
>
> QTAILQ_INSERT_TAIL(&cfg_chg_events, cfg_chg_event, next);
>
> }
Wouldn't QEMU_LOCK_GUARD(&cfg_chg_events_lock) be better since it's a
one line? Or the fact there's no return here makes it insufficient?
[-- Attachment #2: Type: text/html, Size: 924 bytes --]
next prev parent reply other threads:[~2025-06-09 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 18:37 [RFC PATCH v12 0/4] Report vfio-ap configuration changes Rorie Reyes
2025-06-06 18:37 ` [RFC PATCH v12 1/4] hw/vfio/ap: notification handler for AP config changed event Rorie Reyes
2025-06-06 18:37 ` [RFC PATCH v12 2/4] hw/vfio/ap: store object indicating AP config changed in a queue Rorie Reyes
2025-06-09 10:19 ` Anthony Krowiak
2025-06-09 14:00 ` Rorie Reyes [this message]
2025-06-06 18:37 ` [RFC PATCH v12 3/4] hw/vfio/ap: Storing event information for an AP configuration change event Rorie Reyes
2025-06-09 10:40 ` Anthony Krowiak
2025-06-06 18:37 ` [RFC PATCH v12 4/4] s390: implementing CHSC SEI for AP config change Rorie Reyes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b806b24-62fe-4769-80fc-f6afe479e455@linux.ibm.com \
--to=rreyes@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@redhat.com \
--cc=cohuck@redhat.com \
--cc=jjherne@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).