qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
	Stefan Weil <sw@weilnetz.de>, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v2] migration: Fix order of function arguments
Date: Tue, 9 Dec 2025 20:55:45 +0100	[thread overview]
Message-ID: <8b809984-c3e8-4bc8-84ca-92b3d674db92@linaro.org> (raw)
In-Reply-To: <aTh-TUbyMRCfkbS5@x1.local>

On 9/12/25 20:53, Peter Xu wrote:
> On Tue, Dec 09, 2025 at 08:50:10PM +0100, Philippe Mathieu-Daudé wrote:
>> From: Stefan Weil <sw@weilnetz.de>
>>
>> This fixes a compiler error when higher warning levels are enabled:
>>
>> ../migration/postcopy-ram.c: In function ‘postcopy_temp_pages_setup’:
>> ../migration/postcopy-ram.c:1483:50: error: ‘g_malloc0_n’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
>>   1483 |     mis->postcopy_tmp_pages = g_malloc0_n(sizeof(PostcopyTmpPage), channels);
>>        |                                                  ^~~~~~~~~~~~~~~
>> ../migration/postcopy-ram.c:1483:50: note: earlier argument should specify number of elements, later size of each element
>>
>> Avoid also a related int/unsigned mismatch by fixing the type of
>> two local variables.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> Reviewed-by: Laurent Vivier <laurent@vivier.eu>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> [PMD: Replace g_malloc0_n() by g_new0()]
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> Acked-by: Peter Xu <peterx@redhat.com>

Queued, thanks :)



      reply	other threads:[~2025-12-09 19:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-09 19:50 [PATCH v2] migration: Fix order of function arguments Philippe Mathieu-Daudé
2025-12-09 19:53 ` Peter Xu
2025-12-09 19:55   ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b809984-c3e8-4bc8-84ca-92b3d674db92@linaro.org \
    --to=philmd@linaro.org \
    --cc=farosas@suse.de \
    --cc=laurent@vivier.eu \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).