From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:47446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1goNsV-0003Vn-NX for qemu-devel@nongnu.org; Tue, 29 Jan 2019 02:32:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1goNsT-00053b-Ee for qemu-devel@nongnu.org; Tue, 29 Jan 2019 02:32:15 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:42023) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1goNsR-0004xd-Rz for qemu-devel@nongnu.org; Tue, 29 Jan 2019 02:32:13 -0500 Received: by mail-wr1-f67.google.com with SMTP id q18so20792942wrx.9 for ; Mon, 28 Jan 2019 23:32:11 -0800 (PST) References: From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <8b87466e-3e9a-14ae-c827-ac5e61717a87@redhat.com> Date: Tue, 29 Jan 2019 08:32:08 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] macOS build error after ddac19f534 (virtio: split virtio 9p bits from virtio-pci) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: BALATON Zoltan , Greg Kurz Cc: qemu-devel@nongnu.org, Peter Maydell , Juan Quintela , "Michael S. Tsirkin" Hi Zoltan, On 1/29/19 2:20 AM, BALATON Zoltan wrote: > Hello, > > I'm getting error building on macOS after commit ddac19f534: > >   CC      aarch64-softmmu/hw/virtio/virtio-blk-pci.o > In file included from qemu/hw/virtio/virtio-9p-pci.c:19: > In file included from qemu/hw/9pfs/virtio-9p.h:6: > In file included from qemu/hw/9pfs/9p.h:7: > qemu/fsdev/file-op-9p.h:19:10: fatal error: 'sys/vfs.h' file not found > #include >          ^~~~~~~~~~~ > > Am I missing something? (Apart from the include file which is not > present on OS X... Maybe this needs the #ifdefs it had before the split?) It seems commits are not correctly ordered for bisectability :( If you cherry-pick ecd3b89b054, does it build?