From: Richard Henderson <richard.henderson@linaro.org>
To: Andrew Jones <drjones@redhat.com>,
qemu-devel@nongnu.org, qemu-arm@nongnu.org
Cc: f4bug@amsat.org, alex.bennee@linaro.org, cohuck@redhat.com
Subject: Re: [PATCH v2] tests: Prefer max cpu type when using AArch64 virt machine
Date: Fri, 3 Jun 2022 07:04:01 -0700 [thread overview]
Message-ID: <8baf9cbc-3cd4-bcd7-c60d-b68bf0784779@linaro.org> (raw)
In-Reply-To: <20220603111849.1481100-1-drjones@redhat.com>
On 6/3/22 04:18, Andrew Jones wrote:
> The max cpu type is the best default cpu type for tests to use
> when specifying the cpu type for AArch64 mach-virt. Switch all
> tests to it.
>
> Cc: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Andrew Jones <drjones@redhat.com>
For avoidance of doubt, copying v1 comment to v2:
> diff --git a/tests/avocado/replay_kernel.py b/tests/avocado/replay_kernel.py
> index 0b2b0dc692b1..c19022ea977d 100644
> --- a/tests/avocado/replay_kernel.py
> +++ b/tests/avocado/replay_kernel.py
> @@ -147,7 +147,7 @@ def test_aarch64_virt(self):
> """
> :avocado: tags=arch:aarch64
> :avocado: tags=machine:virt
> - :avocado: tags=cpu:cortex-a53
> + :avocado: tags=cpu:max
> """
> kernel_url = ('https://archives.fedoraproject.org/pub/archive/fedora'
> '/linux/releases/29/Everything/aarch64/os/images/pxeboot'
This will *not* work without further changes. Fedora 29 will is old, and will not boot a
cpu with FEAT_LPA2 enabled.
See 11593544df6f ("tests/avocado: update aarch64_virt test to exercise -cpu max")
Which makes me wonder if you've actually tested this?
r~
next prev parent reply other threads:[~2022-06-03 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 11:18 [PATCH v2] tests: Prefer max cpu type when using AArch64 virt machine Andrew Jones
2022-06-03 11:55 ` Cornelia Huck
2022-06-03 13:51 ` Gavin Shan
2022-06-03 14:04 ` Richard Henderson [this message]
2022-06-03 15:15 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8baf9cbc-3cd4-bcd7-c60d-b68bf0784779@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=cohuck@redhat.com \
--cc=drjones@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).