qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Chris Hofstaedtler <zeha@debian.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
	Chris Hofstaedtler <chris@hofstaedtler.name>,
	pbonzini@redhat.com
Subject: Re: [PATCH] meson: fix Cocoa option in summary
Date: Mon, 28 Dec 2020 18:15:59 +0100	[thread overview]
Message-ID: <8bb0e3b7-3d15-3dfd-6ef9-fc639a07ed48@redhat.com> (raw)
In-Reply-To: <20201228150958.232564-1-zeha@debian.org>

Hi Chris,

On 12/28/20 4:09 PM, Chris Hofstaedtler wrote:
> From: Chris Hofstaedtler <chris@hofstaedtler.name>
> 
> Regression introduced in f9332757898.

Isn't it commit b4e312e953b? If so you could add:

Fixes: b4e312e953b ("configure: move cocoa option to Meson")

> Signed-off-by: Chris Hofstaedtler <chris@hofstaedtler.name>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index e864cdd155..9c152a85bd 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2112,7 +2112,7 @@ summary_info += {'strip binaries':    get_option('strip')}
>  summary_info += {'profiler':          config_host.has_key('CONFIG_PROFILER')}
>  summary_info += {'static build':      config_host.has_key('CONFIG_STATIC')}
>  if targetos == 'darwin'
> -  summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
> +  summary_info += {'Cocoa support': config_host_data.get('CONFIG_COCOA', false)}
>  endif
>  # TODO: add back version
>  summary_info += {'SDL support':       sdl.found()}
> 



      reply	other threads:[~2020-12-28 17:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28 15:09 [PATCH] meson: fix Cocoa option in summary Chris Hofstaedtler
2020-12-28 17:15 ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bb0e3b7-3d15-3dfd-6ef9-fc639a07ed48@redhat.com \
    --to=philmd@redhat.com \
    --cc=chris@hofstaedtler.name \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zeha@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).