* [PATCH] meson: fix Cocoa option in summary
@ 2020-12-28 15:09 Chris Hofstaedtler
2020-12-28 17:15 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Chris Hofstaedtler @ 2020-12-28 15:09 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, Chris Hofstaedtler, pbonzini
From: Chris Hofstaedtler <chris@hofstaedtler.name>
Regression introduced in f9332757898.
Signed-off-by: Chris Hofstaedtler <chris@hofstaedtler.name>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index e864cdd155..9c152a85bd 100644
--- a/meson.build
+++ b/meson.build
@@ -2112,7 +2112,7 @@ summary_info += {'strip binaries': get_option('strip')}
summary_info += {'profiler': config_host.has_key('CONFIG_PROFILER')}
summary_info += {'static build': config_host.has_key('CONFIG_STATIC')}
if targetos == 'darwin'
- summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
+ summary_info += {'Cocoa support': config_host_data.get('CONFIG_COCOA', false)}
endif
# TODO: add back version
summary_info += {'SDL support': sdl.found()}
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] meson: fix Cocoa option in summary
2020-12-28 15:09 [PATCH] meson: fix Cocoa option in summary Chris Hofstaedtler
@ 2020-12-28 17:15 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-12-28 17:15 UTC (permalink / raw)
To: Chris Hofstaedtler, qemu-devel
Cc: peter.maydell, Chris Hofstaedtler, pbonzini
Hi Chris,
On 12/28/20 4:09 PM, Chris Hofstaedtler wrote:
> From: Chris Hofstaedtler <chris@hofstaedtler.name>
>
> Regression introduced in f9332757898.
Isn't it commit b4e312e953b? If so you could add:
Fixes: b4e312e953b ("configure: move cocoa option to Meson")
> Signed-off-by: Chris Hofstaedtler <chris@hofstaedtler.name>
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index e864cdd155..9c152a85bd 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2112,7 +2112,7 @@ summary_info += {'strip binaries': get_option('strip')}
> summary_info += {'profiler': config_host.has_key('CONFIG_PROFILER')}
> summary_info += {'static build': config_host.has_key('CONFIG_STATIC')}
> if targetos == 'darwin'
> - summary_info += {'Cocoa support': config_host.has_key('CONFIG_COCOA')}
> + summary_info += {'Cocoa support': config_host_data.get('CONFIG_COCOA', false)}
> endif
> # TODO: add back version
> summary_info += {'SDL support': sdl.found()}
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-28 17:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-28 15:09 [PATCH] meson: fix Cocoa option in summary Chris Hofstaedtler
2020-12-28 17:15 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).