From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-stable@nongnu.org
Subject: Re: [PATCH v2 7/9] chardev/char: Preserve %errno in qemu_chr_write()
Date: Wed, 12 Nov 2025 09:33:22 +0100 [thread overview]
Message-ID: <8be63b9b-28d2-455c-8f67-ec0ed1ed7ee7@linaro.org> (raw)
In-Reply-To: <CAFEAcA_7w2u6VU07caQoRbR203RG0EGmRjcB5rmyzXoe1qFMPg@mail.gmail.com>
On 28/10/25 15:25, Peter Maydell wrote:
> On Wed, 22 Oct 2025 at 16:14, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>
>> On 22/10/25 17:07, Philippe Mathieu-Daudé wrote:
>>> qemu_chr_write() dispatches to ChardevClass::chr_write(),
>>> and is expected to propagate the backend error, not some
>>> unrelated one produce by "best effort" logfile or replay.
>>> Preserve and return the relevant %errno.
>>>
>>> Cc: qemu-stable@nongnu.org
>>
>> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
>
> ...did I? I remember being confused by the errno usage
> in these functions but I don't remember what I thought
> was the best way to untangle it...
In March when reviewing PL011 TX FIFO patches ;)
https://lore.kernel.org/qemu-devel/CAFEAcA_kEndvNtw4EHySXWwQPoGs029yAzZGGBcV=zGHaj7KUQ@mail.gmail.com/
next prev parent reply other threads:[~2025-11-12 8:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 15:07 [PATCH v2 0/9] chardev: Improve @docstring and clarify qemu_chr_write() uses Philippe Mathieu-Daudé
2025-10-22 15:07 ` [PATCH v2 1/9] chardev/char-fe: Improve @docstrings Philippe Mathieu-Daudé
2025-10-22 15:07 ` [PATCH v2 2/9] chardev/char-io: Add @docstrings for io_channel_send[_full]() Philippe Mathieu-Daudé
2025-10-22 15:07 ` [PATCH v2 3/9] chardev/char: Improve ChardevClass::chr_write() docstring Philippe Mathieu-Daudé
2025-10-28 13:30 ` Marc-André Lureau
2025-10-22 15:07 ` [PATCH v2 4/9] chardev/char: Document qemu_chr_write[_all]() Philippe Mathieu-Daudé
2025-10-28 13:32 ` Marc-André Lureau
2025-10-22 15:07 ` [PATCH v2 5/9] chardev/char-pty: Do not ignore chr_write() failures Philippe Mathieu-Daudé
2025-10-28 13:44 ` Marc-André Lureau
2025-11-12 12:51 ` Philippe Mathieu-Daudé
2025-10-22 15:07 ` [PATCH v2 6/9] chardev/char: Allow partial writes in qemu_chr_write() Philippe Mathieu-Daudé
2025-10-28 13:53 ` Marc-André Lureau
2025-10-22 15:07 ` [PATCH v2 7/9] chardev/char: Preserve %errno " Philippe Mathieu-Daudé
2025-10-22 15:14 ` Philippe Mathieu-Daudé
2025-10-28 14:25 ` Peter Maydell
2025-11-12 8:33 ` Philippe Mathieu-Daudé [this message]
2025-10-28 14:00 ` Marc-André Lureau
2025-10-28 14:19 ` Daniel P. Berrangé
2025-10-22 15:07 ` [PATCH v2 8/9] chardev/char-hub: Retry when qemu_chr_fe_write() can not write Philippe Mathieu-Daudé
2025-10-28 14:04 ` Marc-André Lureau
2025-10-22 15:07 ` [PATCH v2 9/9] hw/char: Simplify when qemu_chr_fe_write() could " Philippe Mathieu-Daudé
2025-10-28 14:07 ` Marc-André Lureau
2025-10-22 15:16 ` [PATCH v2 0/9] chardev: Improve @docstring and clarify qemu_chr_write() uses Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8be63b9b-28d2-455c-8f67-ec0ed1ed7ee7@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).