From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A80C433E2 for ; Tue, 1 Sep 2020 17:43:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BD0B206FA for ; Tue, 1 Sep 2020 17:43:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Kfaihqzn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BD0B206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kDAJt-0000Zp-Rr for qemu-devel@archiver.kernel.org; Tue, 01 Sep 2020 13:43:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kDAH4-0005in-EE for qemu-devel@nongnu.org; Tue, 01 Sep 2020 13:40:51 -0400 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]:36222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kDAH2-0001aV-Ku for qemu-devel@nongnu.org; Tue, 01 Sep 2020 13:40:50 -0400 Received: by mail-pg1-x543.google.com with SMTP id p37so1062519pgl.3 for ; Tue, 01 Sep 2020 10:40:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=66gQa6kGpxBdIN5DQxQg6iycf5I0HYWdCFEL/9u+eTA=; b=KfaihqznucikKrpqj+xTZgf5dpa96trExqYE9+D60p+bZ6BeolyimSZuZAeJXHQnFc b0v/Qij4hRcGYPXCRbRzNTk/TTlVo9LOmjQBXQj6z+21ZB2wEfr3fyJJI1Kz0qccI02X wo5ocirYP9TuYTGxZ1Kb/tMVuZeE66v9sQqpM62geoGZg+hQ0khS423ojUnS0CofvyH2 79VfdU0XFgLpLtZdLN31NvxX1e4NEmUgTCW1/Osl8mu7yCuQztiBJvv3oYz3GO9GTcUs ziR2R7I2NeHH7L8nTl1vCTvmqvsWsE9EMQU+6e05wAhrwBY7fjaaBRGbaJRsL8yqmqCH QUug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=66gQa6kGpxBdIN5DQxQg6iycf5I0HYWdCFEL/9u+eTA=; b=DbHbtOorMgSvy7FWTAl/zhtVGqEvppLpMxmIc3NRmjFTkD+jLNPjF1XuH4CvWaQQv1 OT7u9yO4oAL1qQnIeCfSqyqWD+vtjtqZojuqyfe6wVV0Ry4mBm21nHQDRMmAzuvI5YdP 0HQqsEwXnL5zS7jgBMlsIFJKdirnDSzHEL8/xUcyp3GbA4+QO7z+2cAzsz4z9eSRT8Tq N2ubpApjNd9fzMYYr+XV5dIUlNd40WXGJuyzOumrvbSOl1DajQy9qWq7db5kwz7t9wfO WMTn0I9YXoCrqU938yRrkAt8QqeJr4beU+nHdGS1re0cwIe2WIHSdIiseXDFqKXUbjzm LpJQ== X-Gm-Message-State: AOAM533CG2TqTnndfuJB/lRzi9rKRCnFoFmL7k/ZFZFwYGad65DsZAXs fsTN94ToqBb0tzbZvGQ/Sc0A3g== X-Google-Smtp-Source: ABdhPJxvv/h7/Ut96ncHHUlLpDyykL4dvs3wsdfCId80dIFUVJZFwEwLnfQMJNvBuypTFZ1TsVZ5TQ== X-Received: by 2002:a62:19cd:: with SMTP id 196mr2848299pfz.143.1598982046852; Tue, 01 Sep 2020 10:40:46 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id h8sm2613426pfr.195.2020.09.01.10.40.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Sep 2020 10:40:46 -0700 (PDT) Subject: Re: [PATCH v6 11/16] cpus: remove checks for non-NULL cpus_accel To: Claudio Fontana , Paolo Bonzini , Richard Henderson , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Roman Bolshakov References: <20200901072201.7133-1-cfontana@suse.de> <20200901072201.7133-12-cfontana@suse.de> From: Richard Henderson Message-ID: <8bf0e29d-4801-c06c-c19f-408aaa7e631f@linaro.org> Date: Tue, 1 Sep 2020 10:40:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200901072201.7133-12-cfontana@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::543; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x543.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.13, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Alberto Garcia , Eduardo Habkost , Marcelo Tosatti , qemu-devel@nongnu.org, Markus Armbruster , Pavel Dovgalyuk , Colin Xu , haxm-team@intel.com, Sunil Muthuswamy , Wenchao Wang Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/1/20 12:21 AM, Claudio Fontana wrote: > now that all accelerators support the CpusAccel interface, > we can remove most checks for non-NULL cpus_accel, > we just add a sanity check/assert at vcpu creation. > > Signed-off-by: Claudio Fontana > --- > softmmu/cpus.c | 33 +++++++++++++++++++++------------ > 1 file changed, 21 insertions(+), 12 deletions(-) Reviewed-by: Richard Henderson r~