From: Laszlo Ersek <lersek@redhat.com>
To: Eric Auger <eric.auger@redhat.com>,
eric.auger.pro@gmail.com, qemu-devel@nongnu.org,
qemu-arm@nongnu.org, peter.maydell@linaro.org
Cc: wei@redhat.com, drjones@redhat.com, ard.biesheuvel@linaro.org,
marc.zyngier@arm.com, christoffer.dall@arm.com,
zhaoshenglong@huawei.com
Subject: Re: [Qemu-devel] [PATCH 9/9] hw/arm/virt: Add virt-3.0 machine type
Date: Wed, 13 Jun 2018 23:05:41 +0200 [thread overview]
Message-ID: <8bf1bccc-b32a-9982-6123-b644c41a96d3@redhat.com> (raw)
In-Reply-To: <1528879723-24675-10-git-send-email-eric.auger@redhat.com>
On 06/13/18 10:48, Eric Auger wrote:
> PATCH: merge of ECAM and VCPU extension
> - Laszlo reviewed the ECAM changes but I dropped his R-b
> due to the squash
Was there any particular reason why the previous patch set (with only
the ECAM enlargement) couldn't be merged first? To be honest I'm not
super happy when my R-b is dropped for non-technical reasons; it seems
like wasted work for both of us.
Obviously if there's a technical dependency or some other reason why
committing the ECAM enlargement in separation would be *wrong*, that's
different. Even in that case, wouldn't it be possible to keep the
initial virt-3.0 machtype addition as I reviewed it, and then add the
rest in an incremental patch?
Thanks,
Laszlo
next prev parent reply other threads:[~2018-06-13 21:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 8:48 [Qemu-devel] [PATCH 0/9] KVM/ARM: virt-3.0: Multiple redistributor regions and 256MB ECAM region Eric Auger
2018-06-13 8:48 ` [Qemu-devel] [PATCH 1/9] linux-headers: Update to 4.18-rc0 Eric Auger
2018-06-13 8:48 ` [Qemu-devel] [PATCH 2/9] target/arm: Allow KVM device address overwriting Eric Auger
2018-06-13 8:48 ` [Qemu-devel] [PATCH 3/9] hw/intc/arm_gicv3: Introduce redist-region-count array property Eric Auger
2018-06-14 13:32 ` Andrew Jones
2018-06-14 13:55 ` Auger Eric
2018-06-14 14:06 ` Andrew Jones
2018-06-13 8:48 ` [Qemu-devel] [PATCH 4/9] hw/intc/arm_gicv3_kvm: Get prepared to handle multiple redist regions Eric Auger
2018-06-14 13:39 ` Andrew Jones
2018-06-14 13:48 ` Auger Eric
2018-06-14 14:03 ` Andrew Jones
2018-06-13 8:48 ` [Qemu-devel] [PATCH 5/9] hw/arm/virt: GICv3 DT node with one or two redistributor regions Eric Auger
2018-06-14 13:21 ` Andrew Jones
2018-06-13 8:48 ` [Qemu-devel] [PATCH 6/9] hw/arm/virt-acpi-build: Advertise one or two GICR structures Eric Auger
2018-06-14 13:43 ` Andrew Jones
2018-06-13 8:48 ` [Qemu-devel] [PATCH 7/9] hw/arm/virt: Register two redistributor regions when necessary Eric Auger
2018-06-14 13:45 ` Andrew Jones
2018-06-13 8:48 ` [Qemu-devel] [PATCH 8/9] hw/arm/virt: Add a new 256MB ECAM region Eric Auger
2018-06-14 13:53 ` Andrew Jones
2018-06-13 8:48 ` [Qemu-devel] [PATCH 9/9] hw/arm/virt: Add virt-3.0 machine type Eric Auger
2018-06-13 21:05 ` Laszlo Ersek [this message]
2018-06-14 6:27 ` Auger Eric
2018-06-14 8:56 ` Laszlo Ersek
2018-06-14 8:59 ` Daniel P. Berrangé
2018-06-14 9:04 ` Auger Eric
2018-06-14 9:03 ` Auger Eric
2018-06-14 14:17 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bf1bccc-b32a-9982-6123-b644c41a96d3@redhat.com \
--to=lersek@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=christoffer.dall@arm.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=marc.zyngier@arm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wei@redhat.com \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).