From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] tests/functional: ensure GDB client is stopped on error
Date: Thu, 16 Oct 2025 11:29:40 +0200 [thread overview]
Message-ID: <8bf630e8-9c3f-4d2d-8f68-a4abcca54f64@redhat.com> (raw)
In-Reply-To: <20251014140047.385347-3-berrange@redhat.com>
On 14/10/2025 16.00, Daniel P. Berrangé wrote:
> If the reverse_debugging_run method fails, the GDB client will not
> be closed resulting in python complaining about resource leaks.
> Hoisting the GDB client creation into the caller allows this to
> be cleaned up easily. While doing this, also move the VM shutdown
> call to match.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/functional/reverse_debugging.py | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2025-10-16 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 14:00 [PATCH 0/2] tests/functional: cleanup leftovers from reverse debugging test Daniel P. Berrangé
2025-10-14 14:00 ` [PATCH 1/2] tests/functional: remove use of getLogger in reverse debuging Daniel P. Berrangé
2025-10-16 9:27 ` Thomas Huth
2025-10-14 14:00 ` [PATCH 2/2] tests/functional: ensure GDB client is stopped on error Daniel P. Berrangé
2025-10-16 9:29 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bf630e8-9c3f-4d2d-8f68-a4abcca54f64@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).