[Qemu-devel] About my strnlen patch

[Qemu-devel] About my strnlen patch

[Programmingkid]

Now would be a good time to push the strnlen patch. 

Re: [Qemu-devel] About my strnlen patch

[Eric Blake]

On 12/21/2017 08:31 AM, Programmingkid wrote:
> Now would be a good time to push the strnlen patch.

No links to the patch? Generally, when pinging a patch, it's best to 
reply to the existing thread, or at least provide a URL to the thread, 
where the patch was proposed.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] About my strnlen patch

[Programmingkid]

> On Dec 21, 2017, at 1:30 PM, Eric Blake <eblake@redhat.com> wrote:
> 
> On 12/21/2017 08:31 AM, Programmingkid wrote:
>> Now would be a good time to push the strnlen patch.
> 
> No links to the patch? Generally, when pinging a patch, it's best to reply to the existing thread, or at least provide a URL to the thread, where the patch was proposed.
> 
Yes here is the patch: https://patchwork.kernel.org/patch/10027375/

Re: [Qemu-devel] About my strnlen patch

[Eric Blake]

On 12/21/2017 12:36 PM, Programmingkid wrote:
> 
>> On Dec 21, 2017, at 1:30 PM, Eric Blake <eblake@redhat.com> wrote:
>>
>> On 12/21/2017 08:31 AM, Programmingkid wrote:
>>> Now would be a good time to push the strnlen patch.
>>
>> No links to the patch? Generally, when pinging a patch, it's best to reply to the existing thread, or at least provide a URL to the thread, where the patch was proposed.
>>
> Yes here is the patch: https://patchwork.kernel.org/patch/10027375/

And that link says it was applied to libfdt on Oct 25.  What still needs 
to happen that caused you to send this ping?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] About my strnlen patch

[Programmingkid]

> On Dec 21, 2017, at 1:40 PM, Eric Blake <eblake@redhat.com> wrote:
> 
> On 12/21/2017 12:36 PM, Programmingkid wrote:
>>> On Dec 21, 2017, at 1:30 PM, Eric Blake <eblake@redhat.com> wrote:
>>> 
>>> On 12/21/2017 08:31 AM, Programmingkid wrote:
>>>> Now would be a good time to push the strnlen patch.
>>> 
>>> No links to the patch? Generally, when pinging a patch, it's best to reply to the existing thread, or at least provide a URL to the thread, where the patch was proposed.
>>> 
>> Yes here is the patch: https://patchwork.kernel.org/patch/10027375/
> 
> And that link says it was applied to libfdt on Oct 25.  What still needs to happen that caused you to send this ping?

It isn't available in QEMU yet. Without the patch building QEMU on Mac OS 10.6 fails. 

The patch'ed code would be found here: <qemu folder>/dtc/libfdt/libfdt_env.h.

I can check on the patch's status by deleting the dtc folder and retrieve it again using this command:
$ scripts/git-submodule.sh dtc

Re: [Qemu-devel] About my strnlen patch

[Eric Blake]

On 12/21/2017 01:07 PM, Programmingkid wrote:
> 
>> On Dec 21, 2017, at 1:40 PM, Eric Blake <eblake@redhat.com> wrote:
>>
>> On 12/21/2017 12:36 PM, Programmingkid wrote:
>>>> On Dec 21, 2017, at 1:30 PM, Eric Blake <eblake@redhat.com> wrote:
>>>>
>>>> On 12/21/2017 08:31 AM, Programmingkid wrote:
>>>>> Now would be a good time to push the strnlen patch.
>>>>
>>>> No links to the patch? Generally, when pinging a patch, it's best to reply to the existing thread, or at least provide a URL to the thread, where the patch was proposed.
>>>>
>>> Yes here is the patch: https://patchwork.kernel.org/patch/10027375/
>>
>> And that link says it was applied to libfdt on Oct 25.  What still needs to happen that caused you to send this ping?
> 
> It isn't available in QEMU yet. Without the patch building QEMU on Mac OS 10.6 fails.
> 
> The patch'ed code would be found here: <qemu folder>/dtc/libfdt/libfdt_env.h.
> 
> I can check on the patch's status by deleting the dtc folder and retrieve it again using this command:
> $ scripts/git-submodule.sh dtc

In other words, for qemu, you are proposing a patch to update the dtc 
submodule to a newer commit id.  Instead of describing that in words, 
it's better to post an actual patch, such as this, which updates to the 
latest dtc commit available as of my email:

diff --git i/dtc w/dtc
index 558cd81bdd..e671852042 160000
--- i/dtc
+++ w/dtc
@@ -1 +1 @@
-Subproject commit 558cd81bdd432769b59bff01240c44f82cfb1a9d
+Subproject commit e671852042a77b15ec72ca908291c7d647e4fb01

Create such a patch by: 'cd dtc; git pull; git merge origin; cd ..; git 
add dtc'.  However, pointing the dtc submodule to a commit in-between 
releases may not be desirable; your commit landed in dtc as commit 
c8f8194d, missing v1.4.5 (qemu.git is currently pointing to v1.4.4).  As 
I'm not the maintainer of the dtc submodule, I don't know the preferred 
submodule update procedure; it may mean that you have to wait for 
upstream dtc to release v1.4.6 before qemu.git can be updated to point 
to a dtc version that includes your commit.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org