From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
devel@lists.libvirt.org, David Hildenbrand <david@redhat.com>,
Ani Sinha <anisinha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH-for-9.1 07/18] target/i386/kvm: Remove x86_cpu_change_kvm_default() and 'kvm-cpu.h'
Date: Wed, 6 Mar 2024 17:53:07 +0100 [thread overview]
Message-ID: <8bfad1f4-8fcb-42ad-ad43-80a72a448959@redhat.com> (raw)
In-Reply-To: <20240305134221.30924-8-philmd@linaro.org>
On 05/03/2024 14.42, Philippe Mathieu-Daudé wrote:
> x86_cpu_change_kvm_default() was only used out of kvm-cpu.c by
> the pc-i440fx-2.1 machine, which got removed. Inline it, and
s/Inline/Make it static/ ?
(since it is not a real inlining here)
> remove its declaration. "kvm-cpu.h" is now empty, remove it too.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/i386/kvm/kvm-cpu.h | 41 ---------------------------------------
> target/i386/kvm/kvm-cpu.c | 3 +--
> 2 files changed, 1 insertion(+), 43 deletions(-)
> delete mode 100644 target/i386/kvm/kvm-cpu.h
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-03-06 16:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 13:42 [PATCH-for-9.1 00/18] hw/i386: Remove deprecated pc-i440fx-2.0 -> 2.3 machines Philippe Mathieu-Daudé
2024-03-05 13:42 ` [PATCH-for-9.1 01/18] hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine Philippe Mathieu-Daudé
2024-03-06 16:41 ` Thomas Huth
2024-03-27 9:24 ` Philippe Mathieu-Daudé
2024-03-05 13:42 ` [PATCH-for-9.1 02/18] hw/usb/hcd-xhci: Enumerate xhci_flags setting values Philippe Mathieu-Daudé
2024-03-06 13:27 ` Zhao Liu
2024-03-06 16:09 ` Philippe Mathieu-Daudé
2024-03-05 13:42 ` [PATCH-for-9.1 03/18] hw/usb/hcd-xhci: Remove XHCI_FLAG_FORCE_PCIE_ENDCAP flag Philippe Mathieu-Daudé
2024-03-06 16:13 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 04/18] hw/usb/hcd-xhci: Remove XHCI_FLAG_SS_FIRST flag Philippe Mathieu-Daudé
2024-03-06 16:17 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 05/18] hw/i386/acpi: Remove PCMachineClass::legacy_acpi_table_size Philippe Mathieu-Daudé
2024-03-06 16:24 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 06/18] hw/i386/pc: Remove deprecated pc-i440fx-2.1 machine Philippe Mathieu-Daudé
2024-03-06 17:02 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 07/18] target/i386/kvm: Remove x86_cpu_change_kvm_default() and 'kvm-cpu.h' Philippe Mathieu-Daudé
2024-03-06 16:53 ` Thomas Huth [this message]
2024-03-05 13:42 ` [PATCH-for-9.1 08/18] hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded Philippe Mathieu-Daudé
2024-03-06 16:54 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 09/18] hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm Philippe Mathieu-Daudé
2024-03-06 16:57 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 10/18] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug() Philippe Mathieu-Daudé
2024-03-06 16:58 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 11/18] hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug() Philippe Mathieu-Daudé
2024-03-06 17:00 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 12/18] hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine Philippe Mathieu-Daudé
2024-03-06 18:24 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 13/18] hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob Philippe Mathieu-Daudé
2024-03-06 17:09 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 14/18] hw/i386/pc: Remove PCMachineClass::rsdp_in_ram Philippe Mathieu-Daudé
2024-03-06 17:18 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 15/18] hw/i386/acpi: Remove AcpiBuildState::rsdp field Philippe Mathieu-Daudé
2024-03-06 17:19 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 16/18] hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine Philippe Mathieu-Daudé
2024-03-06 16:01 ` Thomas Huth
2024-03-05 13:42 ` [PATCH-for-9.1 17/18] target/i386: Remove X86CPU::kvm_no_smi_migration field Philippe Mathieu-Daudé
2024-03-06 18:30 ` Thomas Huth
2024-03-27 9:33 ` Philippe Mathieu-Daudé
2024-03-05 13:42 ` [PATCH-for-9.1 18/18] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE Philippe Mathieu-Daudé
2024-03-06 18:32 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bfad1f4-8fcb-42ad-ad43-80a72a448959@redhat.com \
--to=thuth@redhat.com \
--cc=anisinha@redhat.com \
--cc=david@redhat.com \
--cc=devel@lists.libvirt.org \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).