From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>,
clg@kaod.org, peter.maydell@linaro.org, andrew@aj.id.au,
joel@jms.id.au, qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] Adding new machine Yosemitev2 in QEMU
Date: Thu, 16 Feb 2023 12:10:07 +0100 [thread overview]
Message-ID: <8c18d24f-2454-11f2-0322-529ece683629@linaro.org> (raw)
In-Reply-To: <20230216104820.192624-1-pkarthikeyan1509@gmail.com>
Hi Pasupathi,
On 16/2/23 11:48, Karthikeyan Pasupathi wrote:
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> ---
> hw/arm/aspeed.c | 38 ++++++++++++++++++++++++++++++++++++++
> hw/arm/aspeed_eeprom.c | 23 +++++++++++++++++++++++
> hw/arm/aspeed_eeprom.h | 3 +++
> 3 files changed, 64 insertions(+)
> +static void yosemitev2_bmc_i2c_init(AspeedMachineState *bmc)
> +{
> + AspeedSoCState *soc = &bmc->soc;
> +
> + I2CBus *i2c[16];
> +
> + for (int i = 0; i < 16; i++) {
> + i2c[i] = aspeed_i2c_get_bus(&soc->i2c, i);
> + }
> +
> + at24c_eeprom_init(i2c[4], 0x51, 128 * KiB);
> +
> + at24c_eeprom_init_rom(i2c[8], 0x51, 128 * KiB, fbyv2_bmc_fruid,
> + fbyv2_bmc_fruid_len);
This can be simplified as:
at24c_eeprom_init(aspeed_i2c_get_bus(&soc->i2c, 4), 0x51, 128 * KiB);
at24c_eeprom_init_rom(aspeed_i2c_get_bus(&soc->i2c, 8), 0x51, 128 * KiB,
fbyv2_bmc_fruid, fbyv2_bmc_fruid_len);
> +}
prev parent reply other threads:[~2023-02-16 11:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 10:48 [PATCH] Adding new machine Yosemitev2 in QEMU Karthikeyan Pasupathi
2023-02-16 11:10 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c18d24f-2454-11f2-0322-529ece683629@linaro.org \
--to=philmd@linaro.org \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=pkarthikeyan1509@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).