From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Chen Qun <kuhn.chenqun@huawei.com>,
Richard Henderson <richard.henderson@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough
Date: Fri, 11 Dec 2020 16:55:30 +0100 [thread overview]
Message-ID: <8c24cb0c-391e-3f65-d01d-f7d32e12f9a7@redhat.com> (raw)
In-Reply-To: <20201211152426.350966-1-thuth@redhat.com>
On 11/12/2020 16.24, Thomas Huth wrote:
> Coverity is already reporting switch-case statements where code
> can fall through from one case to another without a proper comment
> (since this could indicate a missing "break" and thus a bug).
> However, it's cumbersome to fix these issues after they have been
> merged already, it would be better if the author of the code would
> already take care of this when writing the patch. Fortunately,
> GCC and Clang can already warn about those code spots, too.
> So let's fix our remaining statements that fall through without
> a proper comment, so we can finally turn on -Wimplicit-fallthrough
> for all compilation runs.
>
> Chen Qun (6):
> hw/timer/renesas_tmr: silence the compiler warnings
> target/i386: silence the compiler warnings in gen_shiftd_rm_T1
> hw/intc/arm_gicv3_kvm: silence the compiler warnings
> accel/tcg/user-exec: silence the compiler warnings
> target/sparc/translate: silence the compiler warnings
> target/sparc/win_helper: silence the compiler warnings
>
> Thomas Huth (6):
> disas/libvixl: Fix fall-through annotation for GCC >= 7
> target/unicore32/translate: Add missing fallthrough annotations
> hw/rtc/twl92230: Silence warnings about missing fallthrough statements
> tcg/optimize: Add fallthrough annotations
> tests/fp: Do not emit implicit-fallthrough warnings in the softfloat
> tests
> configure: Compile with -Wimplicit-fallthrough=2
I forgot to mention: There are two more spots in the ppc code that currently
cause some warnings, but the patches to fix those are already in David
Gibson's ppc pull request, so they should be handled soon.
Thomas
next prev parent reply other threads:[~2020-12-11 16:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 15:24 [PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough Thomas Huth
2020-12-11 15:24 ` [PATCH 01/12] disas/libvixl: Fix fall-through annotation for GCC >= 7 Thomas Huth
2020-12-11 15:35 ` Peter Maydell
2020-12-11 15:24 ` [PATCH 02/12] target/unicore32/translate: Add missing fallthrough annotations Thomas Huth
2020-12-11 15:24 ` [PATCH 03/12] hw/rtc/twl92230: Silence warnings about missing fallthrough statements Thomas Huth
2020-12-11 15:37 ` Peter Maydell
2020-12-11 15:24 ` [PATCH 04/12] hw/timer/renesas_tmr: silence the compiler warnings Thomas Huth
2020-12-11 15:38 ` Peter Maydell
2020-12-11 15:46 ` Thomas Huth
2020-12-11 15:24 ` [PATCH 05/12] target/i386: silence the compiler warnings in gen_shiftd_rm_T1 Thomas Huth
2020-12-11 15:24 ` [PATCH 06/12] hw/intc/arm_gicv3_kvm: silence the compiler warnings Thomas Huth
2020-12-11 15:24 ` [PATCH 07/12] accel/tcg/user-exec: " Thomas Huth
2020-12-11 15:24 ` [PATCH 08/12] target/sparc/translate: " Thomas Huth
2020-12-11 15:24 ` [PATCH 09/12] target/sparc/win_helper: " Thomas Huth
2020-12-11 15:24 ` [PATCH 10/12] tcg/optimize: Add fallthrough annotations Thomas Huth
2020-12-11 15:45 ` Richard Henderson
2020-12-11 15:24 ` [PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings in the softfloat tests Thomas Huth
2020-12-11 15:46 ` Richard Henderson
2020-12-12 7:58 ` Chenqun (kuhn)
2020-12-11 15:24 ` [PATCH 12/12] configure: Compile with -Wimplicit-fallthrough=2 Thomas Huth
2020-12-11 15:42 ` Peter Maydell
2020-12-12 9:19 ` Chenqun (kuhn)
2020-12-11 15:55 ` Thomas Huth [this message]
2020-12-11 17:06 ` [PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c24cb0c-391e-3f65-d01d-f7d32e12f9a7@redhat.com \
--to=thuth@redhat.com \
--cc=kuhn.chenqun@huawei.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).