qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>
Subject: Re: [PATCH] target/mips: make SEMIHOSTING conditional on TCG
Date: Wed, 8 Jun 2022 08:14:22 -0700	[thread overview]
Message-ID: <8c3735a8-3de1-d096-26c9-912997d26db0@linaro.org> (raw)
In-Reply-To: <20220608104054.323642-1-alex.bennee@linaro.org>

On 6/8/22 03:40, Alex Bennée wrote:
> Previously SEMIHOSTING was always selected due to requirements in the
> helper files. Since the original fix there has been refactoring in the
> mips code to split TCG and KVM code. The recent semihosting
> refactoring triggers the inverse build problem for KVM only mips
> builds. Instead of selecting it in the common config make it optional
> on TCG being enabled in the target Kconfig.
> 
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> Cc: Richard Henderson<richard.henderson@linaro.org>
> ---
>   configs/devices/mips-softmmu/common.mak | 3 ---
>   target/mips/Kconfig                     | 1 +
>   2 files changed, 1 insertion(+), 3 deletions(-)

Awesome, thanks.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


  reply	other threads:[~2022-06-08 15:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-08 10:40 [PATCH] target/mips: make SEMIHOSTING conditional on TCG Alex Bennée
2022-06-08 15:14 ` Richard Henderson [this message]
2022-06-08 15:22   ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c3735a8-3de1-d096-26c9-912997d26db0@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=f4bug@amsat.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).