From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/5] hw/arm/omap1: Drop ALMDEBUG ifdeffed out code
Date: Thu, 27 Feb 2025 23:15:47 +0100 [thread overview]
Message-ID: <8c4bb9d0-6dc1-409f-8fd1-4c711487b46e@linaro.org> (raw)
In-Reply-To: <20250227170117.1726895-3-peter.maydell@linaro.org>
On 27/2/25 18:01, Peter Maydell wrote:
> In omap1.c, there are some debug printfs in the omap_rtc_write()
> function that are guardad by ifdef ALMDEBUG. ALMDEBUG is never
> set, so this is all dead code.
>
> It's not worth the effort of converting all of these to tracepoints;
> a modern tracepoint approach would probably have a single tracepoint
> covering all the register writes anyway. Just delete the printf()s.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/arm/omap1.c | 51 --------------------------------------------------
> 1 file changed, 51 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-02-27 22:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 17:01 [PATCH 0/5] hw/arm: Remove printf() calls Peter Maydell
2025-02-27 17:01 ` [PATCH 1/5] hw/arm/omap1: Convert raw printfs to qemu_log_mask() Peter Maydell
2025-02-27 22:15 ` Philippe Mathieu-Daudé
2025-02-27 17:01 ` [PATCH 2/5] hw/arm/omap1: Drop ALMDEBUG ifdeffed out code Peter Maydell
2025-02-27 22:15 ` Philippe Mathieu-Daudé [this message]
2025-02-27 17:01 ` [PATCH 3/5] hw/arm/omap1: Convert information printfs to tracepoints Peter Maydell
2025-02-27 22:17 ` Philippe Mathieu-Daudé
2025-02-27 17:01 ` [PATCH 4/5] hw/arm/omap_sx1.c: Remove ifdeffed out debug printf Peter Maydell
2025-02-27 17:01 ` [PATCH 5/5] hw/arm/versatilepb: Convert printfs to LOG_GUEST_ERROR Peter Maydell
2025-02-27 22:18 ` Philippe Mathieu-Daudé
2025-02-27 17:49 ` [PATCH 0/5] hw/arm: Remove printf() calls Richard Henderson
2025-03-03 13:05 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c4bb9d0-6dc1-409f-8fd1-4c711487b46e@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).