From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/2] main_loop: Make main_loop_wait() return void
Date: Fri, 30 Jun 2017 12:47:44 +0200 [thread overview]
Message-ID: <8c5197e7-d53f-74d4-9150-c97673b9cc02@redhat.com> (raw)
In-Reply-To: <1498584769-12439-1-git-send-email-peter.maydell@linaro.org>
On 27/06/2017 19:32, Peter Maydell wrote:
> This patchset removes the useless return value from
> main_loop_wait().
>
> Changes v2->v3:
> * add initial patch which removes the use of the return value
> from the version of main_loop in test-char.c -- it didn't
> really need it anyway.
> * removed unnecessary 'return;' at end of function
>
> NB: I've just also noticed that there is exactly one use in the
> tree of the argument to main_loop_wait() now which doesn't
> pass 'false' -- that is in a function in hw/display/xenfb.c
> that was added 8 years ago with a comment claiming it was
> strictly temporary ;-)
>
>
> Peter Maydell (2):
> tests/test-char.c: Don't use main_loop_wait()'s return value
> main_loop: Make main_loop_wait() return void
>
> include/qemu/main-loop.h | 2 +-
> tests/test-char.c | 6 +-----
> util/main-loop.c | 8 +-------
> 3 files changed, 3 insertions(+), 13 deletions(-)
>
Queued, thanks.
Paolo
next prev parent reply other threads:[~2017-06-30 10:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 17:32 [Qemu-devel] [PATCH v3 0/2] main_loop: Make main_loop_wait() return void Peter Maydell
2017-06-27 17:32 ` [Qemu-devel] [PATCH v3 1/2] tests/test-char.c: Don't use main_loop_wait()'s return value Peter Maydell
2017-06-27 18:07 ` Marc-André Lureau
2017-06-27 17:32 ` [Qemu-devel] [PATCH v3 2/2] main_loop: Make main_loop_wait() return void Peter Maydell
2017-06-30 10:47 ` Paolo Bonzini [this message]
2017-07-06 23:48 ` [Qemu-devel] [PATCH v3 0/2] " no-reply
2017-07-07 0:04 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c5197e7-d53f-74d4-9150-c97673b9cc02@redhat.com \
--to=pbonzini@redhat.com \
--cc=f4bug@amsat.org \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).