From: Richard Henderson <richard.henderson@linaro.org>
To: Yonggang Luo <luoyonggang@gmail.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v4 03/12] tcg: Fixes dup_const link error
Date: Thu, 3 Sep 2020 10:20:41 -0700 [thread overview]
Message-ID: <8c5dd495-abaf-7abc-2ba0-82f13bbd3d02@linaro.org> (raw)
In-Reply-To: <20200903083147.707-4-luoyonggang@gmail.com>
On 9/3/20 1:31 AM, Yonggang Luo wrote:
> Rename function dup_const to dup_const_eval for avoid confliction with macro dup_const
>
> The link error on msys2
>
> Linking target qemu-system-alpha.exe
> C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: libqemu-alpha-softmmu.fa.p/tcg_optimize.c.obj: in function `tcg_optimize':
> E:\CI-Cor-Ready\xemu\qemu-build/../qemu.org/tcg/optimize.c:1106: undefined reference to `dup_const'
> C:/CI-Tools/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: libqemu-alpha-softmmu.fa.p/tcg_tcg-op-vec.c.obj: in function `tcg_gen_dupi_vec':
> E:\CI-Cor-Ready\xemu\qemu-build/../qemu.org/tcg/tcg-op-vec.c:283: undefined reference to `dup_const'
> collect2.exe: error: ld returned 1 exit status
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> include/tcg/tcg.h | 6 +++---
> tcg/tcg-op-gvec.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
No, really, as I asked before: what symbol is present in tcg-op-gvec.c.obj
without this patch?
That you need this, to me says that you've got a broken compiler. This is
bog-standard C. There is nothing windows-specific about it.
r~
next prev parent reply other threads:[~2020-09-03 17:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 8:31 [PATCH v4 00/12] Green the msys2 CI make Yonggang Luo
2020-09-03 8:31 ` [PATCH v4 01/12] configure: fixes dtc not cloned when running msys2 CI Yonggang Luo
2020-09-03 8:31 ` [PATCH v4 02/12] meson: Convert undefsym.sh to undefsym.py Yonggang Luo
2020-09-03 8:31 ` [PATCH v4 03/12] tcg: Fixes dup_const link error Yonggang Luo
2020-09-03 17:20 ` Richard Henderson [this message]
2020-09-03 21:19 ` 罗勇刚(Yonggang Luo)
2020-09-03 23:29 ` Richard Henderson
2020-09-03 8:31 ` [PATCH v4 04/12] tests: handling signal on win32 properly Yonggang Luo
2020-09-03 8:31 ` [PATCH v4 05/12] configure: Fix include and linkage issue on msys2 Yonggang Luo
2020-09-03 8:31 ` [PATCH v4 06/12] block: Fixes nfs on msys2/mingw Yonggang Luo
2020-09-03 14:40 ` Thomas Huth
2020-09-03 8:31 ` [PATCH v4 07/12] osdep: These function are only available on Non-Win32 system Yonggang Luo
2020-09-03 8:31 ` [PATCH v4 08/12] ci: fixes msys2 build by upgrading capstone to 4.0.2 Yonggang Luo
2020-09-03 8:31 ` [PATCH v4 09/12] stubs: qemu_notify_event have no need to stub Yonggang Luo
2020-09-03 8:31 ` [PATCH v4 10/12] meson: Fixes qapi tests Yonggang Luo
2020-09-03 8:31 ` [PATCH v4 11/12] tests: Disable test-image-locking that not works under Win32 Yonggang Luo
2020-09-03 8:31 ` [PATCH v4 12/12] ci: Enable msys2 ci in cirrus Yonggang Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c5dd495-abaf-7abc-2ba0-82f13bbd3d02@linaro.org \
--to=richard.henderson@linaro.org \
--cc=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).