From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsNxb-0002bi-LX for qemu-devel@nongnu.org; Sun, 15 Dec 2013 21:31:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VsNxV-0007Nr-Na for qemu-devel@nongnu.org; Sun, 15 Dec 2013 21:31:07 -0500 Received: from mail-pb0-f42.google.com ([209.85.160.42]:41553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VsNxV-0007Nl-IA for qemu-devel@nongnu.org; Sun, 15 Dec 2013 21:31:01 -0500 Received: by mail-pb0-f42.google.com with SMTP id uo5so4901744pbc.1 for ; Sun, 15 Dec 2013 18:31:00 -0800 (PST) Sender: Peter Crosthwaite From: Peter Crosthwaite Date: Sun, 15 Dec 2013 18:30:28 -0800 Message-Id: <8c671e500390c8be0cc363e887e32867d1d1b0d2.1387160489.git.peter.crosthwaite@xilinx.com> In-Reply-To: References: Subject: [Qemu-devel] [PATCH target-arm v5 04/10] arm/highbank: Use object_new() rather than cpu_arm_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, peter.maydell@linaro.org Cc: peter.crosthwaite@xilinx.com, antonynpavlov@gmail.com, afaerber@suse.de, mark.langsdorf@calxeda.com, mst@redhat.com To allow the machine model to set device properties before CPU realization. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell --- changed since v1: use error_report rather than fprintf(stderr hw/arm/highbank.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index fe98ef1..1d19d8f 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -26,6 +26,7 @@ #include "hw/boards.h" #include "sysemu/blockdev.h" #include "exec/address-spaces.h" +#include "qemu/error-report.h" #define SMP_BOOT_ADDR 0x100 #define SMP_BOOT_REG 0x40 @@ -229,10 +230,15 @@ static void calxeda_init(QEMUMachineInitArgs *args, enum cxmachines machine) } for (n = 0; n < smp_cpus; n++) { + ObjectClass *oc = cpu_class_by_name(TYPE_ARM_CPU, cpu_model); ARMCPU *cpu; - cpu = cpu_arm_init(cpu_model); - if (cpu == NULL) { - fprintf(stderr, "Unable to find CPU definition\n"); + Error *err = NULL; + + cpu = ARM_CPU(object_new(object_class_get_name(oc))); + + object_property_set_bool(OBJECT(cpu), true, "realized", &err); + if (err) { + error_report("%s", error_get_pretty(err)); exit(1); } -- 1.8.5.1