From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E70D3C433DF for ; Wed, 3 Jun 2020 12:44:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B1B1720678 for ; Wed, 3 Jun 2020 12:44:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jB5ScUKP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B1B1720678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48088 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jgSlG-0004Ge-0s for qemu-devel@archiver.kernel.org; Wed, 03 Jun 2020 08:44:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jgSjo-0003En-Nw for qemu-devel@nongnu.org; Wed, 03 Jun 2020 08:43:20 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:32941 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jgSjn-0007KK-K7 for qemu-devel@nongnu.org; Wed, 03 Jun 2020 08:43:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591188198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XcYin7y35jYYXdWG/kUD+2Hivo6bryddO48GMZMd/F0=; b=jB5ScUKPEGKnYXF+IISyfLi4BrMb0kCRZ4Yt0pOj6vdKQ7MIKsiQYKSYiDiUEuG766Im3C yWETM5bmmOiaGsschzaMvNVpTCjVyo55cUpIdNNBFPJOvUrG4a+NFzVH0+7elbwu1dCokm H0It1KgomUnKgnDOyILuEnZFddymSrU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-147-RwLgTo13MD-qderhwcAvLQ-1; Wed, 03 Jun 2020 08:43:16 -0400 X-MC-Unique: RwLgTo13MD-qderhwcAvLQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA51C80058E; Wed, 3 Jun 2020 12:43:15 +0000 (UTC) Received: from [10.36.113.192] (ovpn-113-192.ams2.redhat.com [10.36.113.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id C3A95610F2; Wed, 3 Jun 2020 12:43:10 +0000 (UTC) Subject: Re: [PULL 04/12] hmp: Simplify qom-set From: David Hildenbrand To: "Dr. David Alan Gilbert" References: <20200601184004.272784-1-dgilbert@redhat.com> <20200601184004.272784-5-dgilbert@redhat.com> <87pnai7ymz.fsf@dusky.pond.sub.org> <20200602092601.GD2758@work-vm> <847cb8b5-1507-46cf-495a-952d41a3c2b2@redhat.com> <20200603104306.GC2974@work-vm> <457c1ac7-3281-5e98-481b-34d44e5174de@redhat.com> <20200603114317.GD2974@work-vm> <728b8cf4-7574-776c-c7fe-3ed5e20b33d2@redhat.com> <20200603122413.GE2974@work-vm> Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMFCQlmAYAGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl3pImkCGQEACgkQTd4Q 9wD/g1o+VA//SFvIHUAvul05u6wKv/pIR6aICPdpF9EIgEU448g+7FfDgQwcEny1pbEzAmiw zAXIQ9H0NZh96lcq+yDLtONnXk/bEYWHHUA014A1wqcYNRY8RvY1+eVHb0uu0KYQoXkzvu+s Dncuguk470XPnscL27hs8PgOP6QjG4jt75K2LfZ0eAqTOUCZTJxA8A7E9+XTYuU0hs7QVrWJ jQdFxQbRMrYz7uP8KmTK9/Cnvqehgl4EzyRaZppshruKMeyheBgvgJd5On1wWq4ZUV5PFM4x II3QbD3EJfWbaJMR55jI9dMFa+vK7MFz3rhWOkEx/QR959lfdRSTXdxs8V3zDvChcmRVGN8U Vo93d1YNtWnA9w6oCW1dnDZ4kgQZZSBIjp6iHcA08apzh7DPi08jL7M9UQByeYGr8KuR4i6e RZI6xhlZerUScVzn35ONwOC91VdYiQgjemiVLq1WDDZ3B7DIzUZ4RQTOaIWdtXBWb8zWakt/ ztGhsx0e39Gvt3391O1PgcA7ilhvqrBPemJrlb9xSPPRbaNAW39P8ws/UJnzSJqnHMVxbRZC Am4add/SM+OCP0w3xYss1jy9T+XdZa0lhUvJfLy7tNcjVG/sxkBXOaSC24MFPuwnoC9WvCVQ ZBxouph3kqc4Dt5X1EeXVLeba+466P1fe1rC8MbcwDkoUo65Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAiUEGAECAA8FAlXLn5ECGwwFCQlmAYAACgkQTd4Q 9wD/g1qA6w/+M+ggFv+JdVsz5+ZIc6MSyGUozASX+bmIuPeIecc9UsFRatc91LuJCKMkD9Uv GOcWSeFpLrSGRQ1Z7EMzFVU//qVs6uzhsNk0RYMyS0B6oloW3FpyQ+zOVylFWQCzoyyf227y GW8HnXunJSC+4PtlL2AY4yZjAVAPLK2l6mhgClVXTQ/S7cBoTQKP+jvVJOoYkpnFxWE9pn4t H5QIFk7Ip8TKr5k3fXVWk4lnUi9MTF/5L/mWqdyIO1s7cjharQCstfWCzWrVeVctpVoDfJWp 4LwTuQ5yEM2KcPeElLg5fR7WB2zH97oI6/Ko2DlovmfQqXh9xWozQt0iGy5tWzh6I0JrlcxJ ileZWLccC4XKD1037Hy2FLAjzfoWgwBLA6ULu0exOOdIa58H4PsXtkFPrUF980EEibUp0zFz GotRVekFAceUaRvAj7dh76cToeZkfsjAvBVb4COXuhgX6N4pofgNkW2AtgYu1nUsPAo+NftU CxrhjHtLn4QEBpkbErnXQyMjHpIatlYGutVMS91XTQXYydCh5crMPs7hYVsvnmGHIaB9ZMfB njnuI31KBiLUks+paRkHQlFcgS2N3gkRBzH7xSZ+t7Re3jvXdXEzKBbQ+dC3lpJB0wPnyMcX FOTT3aZT7IgePkt5iC/BKBk3hqKteTnJFeVIT7EC+a6YUFg= Organization: Red Hat GmbH Message-ID: <8c6b3fae-a74c-effa-2d38-5e8cd4c72066@redhat.com> Date: Wed, 3 Jun 2020 14:43:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=david@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/02 23:55:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mszeredi@redhat.com, lukasstraub2@web.de, quintela@redhat.com, qemu-devel@nongnu.org, pannengyuan@huawei.com, f4bug@amsat.org, Markus Armbruster , stefanha@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 03.06.20 14:26, David Hildenbrand wrote: > On 03.06.20 14:24, Dr. David Alan Gilbert wrote: >> * David Hildenbrand (david@redhat.com) wrote: >>> On 03.06.20 13:43, Dr. David Alan Gilbert wrote: >>>> * David Hildenbrand (david@redhat.com) wrote: >>>>> On 03.06.20 12:43, Dr. David Alan Gilbert wrote: >>>>>> * David Hildenbrand (david@redhat.com) wrote: >>>>>>> On 02.06.20 11:26, Dr. David Alan Gilbert wrote: >>>>>>>> * Markus Armbruster (armbru@redhat.com) wrote: >>>>>>>>> "Dr. David Alan Gilbert (git)" writes: >>>>>>>>> >>>>>>>>>> From: "Dr. David Alan Gilbert" >>>>>>>>>> >>>>>>>>>> Simplify qom_set by making it use qmp_qom_set and the JSON parser. >>>>>>>>>> >>>>>>>>>> (qemu) qom-get /machine smm >>>>>>>>>> "auto" >>>>>>>>>> (qemu) qom-set /machine smm "auto" >>>>>>>>>> >>>>>>>>>> Signed-off-by: Dr. David Alan Gilbert >>>>>>>>>> Message-Id: <20200520151108.160598-3-dgilbert@redhat.com> >>>>>>>>>> Reviewed-by: Philippe Mathieu-Daudé >>>>>>>>>> Reviewed-by: Markus Armbruster >>>>>>>>>> Signed-off-by: Dr. David Alan Gilbert >>>>>>>>>> With 's'->'S' type change suggested by Paolo and Markus >>>>>>>>> >>>>>>>>> This is actually more than just simplification, it's disarming a bear >>>>>>>>> trap: the string visitor is restricted to a subset of the QAPI types, >>>>>>>>> and when you qom-set a property with a type it can't handle, QEMU >>>>>>>>> aborts. I mentioned this in the discussion of possible ways out of the >>>>>>>>> qom-get impasse, but missed reraising it in patch review. >>>>>>>>> >>>>>>>>> A suitably amended commit would be nice, but respinning the PR just for >>>>>>>>> that may not be worthwhile. >>>>>>>> >>>>>>>> A bit late; still as long as we're removing bear traps not adding them. >>>>>>> >>>>>>> This breaks qom-set for my (virtio-mem) use case: >>>>>>> >>>>>>> echo "qom-set vm0 requested-size 300M" | sudo nc -U /var/tmp/mon_src >>>>>>> QEMU 5.0.50 monitor - type 'help' for more information >>>>>>> (qemu) qom-set vm0 requested-size 300M >>>>>>> Error: Expecting at most one JSON value >>>>>> >>>>>> Does qom-set vm0 requested-size 300e6 do the same thing? >>>>> >>>>> The property is defined to be of type "size". >>>>> >>>>> (qemu) qom-set vm0 requested-size 300e6 >>>>> Error: Parameter 'requested-size' expects uint64 >>>>> >>>>> (not sure how "size" and "uint64" are mapped here) >>>> >>>> I think the problem here is that the JSON parser is converting anything >>>> with an 'e' as a float; JSON itself doesn't have the distinction >>>> between int and float. >>>> >>> >>> (and just to clarify - I assume you are aware - 300e6 != 300M. So the >>> interface becomes way harder to use in case one wants to specify >>> properly aligned sizes - 300M vs 314572800) >> >> Oops, yes, good point. >> >> I think on balance it's probably best that this keeps supporting JSON; >> although tbh I'm not convinced there are any complex types that can be >> set. >> I'm not seeing a prettier answer. > > So, I have to use a calculator from now on to set a property that I can > set on the QEMU cmdline just fine without it? :( > > This feels like a step backwards, @Markus any way to keep supporting sizes? Or what about adding qom-set-json instead for complex types instead of changing the behavior if an existing interface? -- Thanks, David / dhildenb