From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Nicholas Piggin <npiggin@gmail.com>, qemu-ppc@nongnu.org
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
Harsh Prateek Bora <harshpb@linux.ibm.com>,
Fabiano Rosas <farosas@suse.de>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Coiby Xu <Coiby.Xu@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH 3/4] tests/qtest: Add libqos function for testing msix interrupt status
Date: Thu, 17 Apr 2025 11:43:28 +0200 [thread overview]
Message-ID: <8c6d6586-1d0d-4047-a9f0-34815e7ed00e@linaro.org> (raw)
In-Reply-To: <20250416145918.415674-4-npiggin@gmail.com>
On 16/4/25 16:59, Nicholas Piggin wrote:
> This function is duplicated 3 times, with more potential future users.
> Factor it into libqos, using qtest_memset instead of qtest_writel to
> clear the message just because that looks nicer with the qtest_memread
> used to read it.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> tests/qtest/libqos/pci.h | 2 ++
> tests/qtest/libqos/pci.c | 48 ++++++++++++++++++++++++++
> tests/qtest/libqos/virtio-pci-modern.c | 31 +++--------------
> tests/qtest/libqos/virtio-pci.c | 40 ++++-----------------
> 4 files changed, 62 insertions(+), 59 deletions(-)
Nice cleanup.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-04-17 9:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 14:59 [PATCH 0/4] tests/qtest: Enable spapr dma tests Nicholas Piggin
2025-04-16 14:59 ` [PATCH 1/4] tests/qtest: Enforce zero for the "un-fired" msix message value Nicholas Piggin
2025-04-16 14:59 ` [PATCH 2/4] tests/qtest: Fix virtio msix message endianness Nicholas Piggin
2025-04-16 14:59 ` [PATCH 3/4] tests/qtest: Add libqos function for testing msix interrupt status Nicholas Piggin
2025-04-17 9:43 ` Philippe Mathieu-Daudé [this message]
2025-04-16 14:59 ` [PATCH 4/4] tests/qtest: Enable spapr dma with linear iommu map Nicholas Piggin
2025-04-17 16:18 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c6d6586-1d0d-4047-a9f0-34815e7ed00e@linaro.org \
--to=philmd@linaro.org \
--cc=Coiby.Xu@gmail.com \
--cc=danielhb413@gmail.com \
--cc=e.emanuelegiuseppe@gmail.com \
--cc=farosas@suse.de \
--cc=harshpb@linux.ibm.com \
--cc=lvivier@redhat.com \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).