From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH v3 01/10] target/mips: Rewrite complex ifdef'ry
Date: Tue, 23 Feb 2021 17:21:49 -0800 [thread overview]
Message-ID: <8c8b363c-0332-ed3f-5c49-f3f8df552027@linaro.org> (raw)
In-Reply-To: <20210222223901.2792336-2-f4bug@amsat.org>
On 2/22/21 2:38 PM, Philippe Mathieu-Daudé wrote:
> No need for this obfuscated ifdef'ry, KISS.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/mips/translate.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2021-02-24 1:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 22:38 [PATCH v3 00/10] target/mips: Extract MXU code to new mxu_translate.c file Philippe Mathieu-Daudé
2021-02-22 22:38 ` [PATCH v3 01/10] target/mips: Rewrite complex ifdef'ry Philippe Mathieu-Daudé
2021-02-24 1:21 ` Richard Henderson [this message]
2021-02-22 22:38 ` [PATCH v3 02/10] target/mips: Remove XBurst Media eXtension Unit dead code Philippe Mathieu-Daudé
2021-02-22 22:38 ` [PATCH v3 03/10] target/mips: Remove unused CPUMIPSState* from MXU functions Philippe Mathieu-Daudé
2021-02-24 1:22 ` Richard Henderson
2021-02-22 22:38 ` [PATCH v3 04/10] target/mips: Pass instruction opcode to decode_opc_mxu() Philippe Mathieu-Daudé
2021-02-24 1:22 ` Richard Henderson
2021-02-22 22:38 ` [PATCH v3 05/10] target/mips: Extract decode_ase_mxu() from decode_opc_mxu() Philippe Mathieu-Daudé
2021-02-24 1:25 ` Richard Henderson
2021-02-26 9:09 ` Philippe Mathieu-Daudé
2021-02-22 22:38 ` [PATCH v3 06/10] target/mips: Use OPC_MUL instead of OPC__MXU_MUL Philippe Mathieu-Daudé
2021-02-24 1:34 ` Richard Henderson
2021-02-22 22:38 ` [PATCH v3 07/10] target/mips: Introduce mxu_translate_init() helper Philippe Mathieu-Daudé
2021-02-24 1:36 ` Richard Henderson
2021-02-22 22:38 ` [PATCH v3 08/10] target/mips: Make mxu_translate_init() / decode_ase_mxu() proto public Philippe Mathieu-Daudé
2021-02-24 1:38 ` Richard Henderson
2021-02-22 22:39 ` [PATCH v3 09/10] target/mips: Simplify 64-bit ifdef'ry of MXU code Philippe Mathieu-Daudé
2021-02-24 1:48 ` Richard Henderson
2021-02-22 22:39 ` [PATCH v3 10/10] target/mips: Extract MXU code to new mxu_translate.c file Philippe Mathieu-Daudé
2021-02-24 2:16 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c8b363c-0332-ed3f-5c49-f3f8df552027@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).