From: Brian Cain <quic_bcain@quicinc.com>
To: Brad Smith <brad@comstyle.com>, Thomas Huth <thuth@redhat.com>,
<qemu-devel@nongnu.org>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Subject: Re: [PATCH] tests/functional/qemu_test: Use Python hashlib instead of external programs
Date: Mon, 16 Sep 2024 07:43:55 -0500 [thread overview]
Message-ID: <8c8e878c-ce03-444e-92fe-725e643c287e@quicinc.com> (raw)
In-Reply-To: <81699a4a-1740-4b65-90d9-4f3ce8f48922@comstyle.com>
On 9/13/2024 9:30 PM, Brad Smith wrote:
> On 2024-09-10 10:06 p.m., Brian Cain wrote:
>>
>> On 9/10/2024 5:26 PM, Brad Smith wrote:
>>> On 2024-09-10 4:17 p.m., Thomas Huth wrote:
>>>> Some systems (like OpenBSD) do not have the sha256sum or sha512sum
>>>> programs
>>>> installed by default. Use the Python hashlib instead so we don't
>>>> have to
>>>> rely on the external programs.
>>>
>>> On OpenBSD they're named sha256 and sha512.
>>>
>> Rather than port the test to each OS's particular program names, we
>> should use the portable solution that's included w/Python.
>
> I wasn't trying to imply that the patch wasn't the right direction, it
> is when it comes portability. Just commenting
> on what it says in the commit message. This isn't the first time such
> differences have come up.
>
I see. Good point.
prev parent reply other threads:[~2024-09-16 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 20:17 [PATCH] tests/functional/qemu_test: Use Python hashlib instead of external programs Thomas Huth
2024-09-10 22:26 ` Brad Smith
2024-09-11 2:06 ` Brian Cain
2024-09-14 2:30 ` Brad Smith
2024-09-16 12:43 ` Brian Cain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c8e878c-ce03-444e-92fe-725e643c287e@quicinc.com \
--to=quic_bcain@quicinc.com \
--cc=brad@comstyle.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).