* [PATCH] memory: drop needless argument
@ 2023-10-09 7:52 marcandre.lureau
2023-10-09 8:18 ` Philippe Mathieu-Daudé
2023-10-09 9:26 ` David Hildenbrand
0 siblings, 2 replies; 3+ messages in thread
From: marcandre.lureau @ 2023-10-09 7:52 UTC (permalink / raw)
To: qemu-devel
Cc: Marc-André Lureau, Paolo Bonzini, Peter Xu,
David Hildenbrand, Philippe Mathieu-Daudé
From: Marc-André Lureau <marcandre.lureau@redhat.com>
The argument is unused since commit bdc44640c ("cpu: Use QTAILQ for CPU list").
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
softmmu/memory_mapping.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/softmmu/memory_mapping.c b/softmmu/memory_mapping.c
index d7f1d096e0..8ba9968f8c 100644
--- a/softmmu/memory_mapping.c
+++ b/softmmu/memory_mapping.c
@@ -291,7 +291,7 @@ void guest_phys_blocks_append(GuestPhysBlockList *list)
memory_listener_unregister(&g.listener);
}
-static CPUState *find_paging_enabled_cpu(CPUState *start_cpu)
+static CPUState *find_paging_enabled_cpu(void)
{
CPUState *cpu;
@@ -312,7 +312,7 @@ void qemu_get_guest_memory_mapping(MemoryMappingList *list,
GuestPhysBlock *block;
ram_addr_t offset, length;
- first_paging_enabled_cpu = find_paging_enabled_cpu(first_cpu);
+ first_paging_enabled_cpu = find_paging_enabled_cpu();
if (first_paging_enabled_cpu) {
for (cpu = first_paging_enabled_cpu; cpu != NULL;
cpu = CPU_NEXT(cpu)) {
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] memory: drop needless argument
2023-10-09 7:52 [PATCH] memory: drop needless argument marcandre.lureau
@ 2023-10-09 8:18 ` Philippe Mathieu-Daudé
2023-10-09 9:26 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-10-09 8:18 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel; +Cc: Paolo Bonzini, Peter Xu, David Hildenbrand
On 9/10/23 09:52, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The argument is unused since commit bdc44640c ("cpu: Use QTAILQ for CPU list").
10 years =)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> softmmu/memory_mapping.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] memory: drop needless argument
2023-10-09 7:52 [PATCH] memory: drop needless argument marcandre.lureau
2023-10-09 8:18 ` Philippe Mathieu-Daudé
@ 2023-10-09 9:26 ` David Hildenbrand
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand @ 2023-10-09 9:26 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel
Cc: Paolo Bonzini, Peter Xu, Philippe Mathieu-Daudé
On 09.10.23 09:52, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The argument is unused since commit bdc44640c ("cpu: Use QTAILQ for CPU list").
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-09 9:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-09 7:52 [PATCH] memory: drop needless argument marcandre.lureau
2023-10-09 8:18 ` Philippe Mathieu-Daudé
2023-10-09 9:26 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).