From: Thomas Huth <thuth@redhat.com>
To: Zhao Liu <zhao1.liu@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [PATCH 1/6] target/s390x/cpu_model: Make check_compatibility() return boolean
Date: Fri, 19 Apr 2024 09:30:18 +0200 [thread overview]
Message-ID: <8c9991e6-ab73-4adb-9ef3-ddcad84266ae@redhat.com> (raw)
In-Reply-To: <20240419065712.1225038-2-zhao1.liu@linux.intel.com>
On 19/04/2024 08.57, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> As error.h suggested, the best practice for callee is to return
> something to indicate success / failure.
>
> With returned boolean, there's no need to check @err.
>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> target/s390x/cpu_models.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-04-19 7:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 6:57 [PATCH 0/6] s390x/cpu_models: Misc cleanup on returned error code and local @err variables Zhao Liu
2024-04-19 6:56 ` Philippe Mathieu-Daudé
2024-04-19 6:57 ` [PATCH 1/6] target/s390x/cpu_model: Make check_compatibility() return boolean Zhao Liu
2024-04-19 7:30 ` Thomas Huth [this message]
2024-04-19 6:57 ` [PATCH 2/6] target/s390x/cpu_model: Drop local @err in s390_realize_cpu_model() Zhao Liu
2024-04-19 7:39 ` Thomas Huth
2024-04-19 8:48 ` Zhao Liu
2024-04-19 6:57 ` [PATCH 3/6] target/s390x/cpu_models: Make kvm_s390_get_host_cpu_model() return boolean Zhao Liu
2024-04-19 6:55 ` Philippe Mathieu-Daudé
2024-04-19 7:18 ` Zhao Liu
2024-04-19 7:50 ` Thomas Huth
2024-04-19 8:44 ` Zhao Liu
2024-04-19 9:08 ` Philippe Mathieu-Daudé
2024-04-22 9:03 ` Zhao Liu
2024-04-19 6:57 ` [PATCH 4/6] target/s390x/cpu_models: Drop local @err in get_max_cpu_model() Zhao Liu
2024-04-19 7:52 ` Thomas Huth
2024-04-19 6:57 ` [PATCH 5/6] target/s390x/cpu_models: Make kvm_s390_apply_cpu_model() return boolean Zhao Liu
2024-04-19 7:59 ` Thomas Huth
2024-04-19 6:57 ` [PATCH 6/6] target/s390x/cpu_models_sysemu: Drop local @err in apply_cpu_model() Zhao Liu
2024-04-19 8:00 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c9991e6-ab73-4adb-9ef3-ddcad84266ae@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=zhao1.liu@intel.com \
--cc=zhao1.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).