From: "Annie.li" <annie.li@oracle.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, imammedo@redhat.com, miguel.luis@oracle.com
Subject: Re: [RFC PATCH 01/11] acpi: hmp/qmp: Add hmp/qmp support for system_sleep
Date: Fri, 22 Dec 2023 13:39:02 -0500 [thread overview]
Message-ID: <8c9eb284-f293-fdbd-7cc6-286ac12c8b1f@oracle.com> (raw)
In-Reply-To: <87h6kah0q7.fsf@pond.sub.org>
On 12/22/2023 7:37 AM, Markus Armbruster wrote:
> "Annie.li" <annie.li@oracle.com> writes:
>
>> Hi Markus,
>>
>> On 12/5/2023 3:34 PM, Markus Armbruster wrote:
>>> You neglected to cc: QAPI schema maintainers. I found it by chance.
>>> Next time :)
>> Yep, should have cc to the maintainers.
>>> Annie Li <annie.li@oracle.com> writes:
>>>
>>>> Following hmp/qmp commands are implemented for pressing virtual
>>>> sleep button,
>>>>
>>>> hmp: system_sleep
>>>> qmp: { "execute": "system_sleep" }
>>>>
>>>> These commands put the guest into suspend or other power states
>>>> depending on the power settings inside the guest.
>>> How is this related to system_wakeup?
>> Both 'system_sleep' and 'system_wakeup' trigger the event to notify the
>> guest OSPM the sleep button has been pressed. 'system_wakeup' triggers
>> wake up notification when the guest is in suspend state.
> Thanks. Would it make sens to work this into the QAPI schema doc
> comments somehow?
Sure. It totally makes sense.
Annie
next prev parent reply other threads:[~2023-12-22 18:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 0:21 [RFC PATCH 00/11] Support ACPI Control Method Sleep button Annie Li
2023-12-05 0:23 ` [RFC PATCH 01/11] acpi: hmp/qmp: Add hmp/qmp support for system_sleep Annie Li
2023-12-05 9:44 ` Philippe Mathieu-Daudé
2023-12-05 14:43 ` Annie.li
2023-12-05 20:34 ` Markus Armbruster
2023-12-05 21:46 ` Annie.li
2023-12-22 12:37 ` Markus Armbruster
2023-12-22 18:39 ` Annie.li [this message]
2023-12-05 0:26 ` [RFC PATCH 02/11] acpi: Implement control method sleep button Annie Li
2023-12-05 0:26 ` [RFC PATCH 03/11] test/acpi: allow DSDT table changes Annie Li
2023-12-05 0:27 ` [RFC PATCH 04/11] acpi: Support Control Method sleep button for x86 Annie Li
2023-12-05 0:27 ` [RFC PATCH 05/11] tests/acpi/bios-tables-test: update DSDT tables for Control Method Sleep button Annie Li
2023-12-05 0:28 ` [RFC PATCH 06/11] acpi: Send the GPE event of suspend and wakeup for x86 Annie Li
2023-12-05 0:28 ` [RFC PATCH 07/11] hw/acpi: Add ACPI GED support for the sleep event Annie Li
2023-12-05 0:29 ` [RFC PATCH 08/11] tests/acpi: allow FACP and DSDT table changes for arm/virt Annie Li
2023-12-05 0:29 ` [RFC PATCH 09/11] hw/arm: enable sleep support " Annie Li
2023-12-05 0:30 ` [RFC PATCH 10/11] tests/acpi: Update FACP and DSDT tables for sleep button Annie Li
2023-12-05 0:31 ` [RFC PATCH 11/11] arm/virt: enable sleep support Annie Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c9eb284-f293-fdbd-7cc6-286ac12c8b1f@oracle.com \
--to=annie.li@oracle.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=miguel.luis@oracle.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).