From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:37304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDscP-00061S-Ru for qemu-devel@nongnu.org; Tue, 09 Apr 2019 11:25:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDscO-0006Ab-BF for qemu-devel@nongnu.org; Tue, 09 Apr 2019 11:25:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35948) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDscN-00069l-Uf for qemu-devel@nongnu.org; Tue, 09 Apr 2019 11:25:00 -0400 References: <20190409134536.15548-1-philmd@redhat.com> <20190409134536.15548-3-philmd@redhat.com> From: Laszlo Ersek Message-ID: <8cb9bfab-f213-9dc7-2fb6-96e412ec06ff@redhat.com> Date: Tue, 9 Apr 2019 17:24:43 +0200 MIME-Version: 1.0 In-Reply-To: <20190409134536.15548-3-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-4.0 v3 2/2] roms: Allow passing configure options to the EDK2 build tools List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Olaf Hering Cc: Gerd Hoffmann , "Michael S . Tsirkin" , Paolo Bonzini , Igor Mammedov On 04/09/19 15:45, Philippe Mathieu-Daud=C3=A9 wrote: > Since commit f590a812c210 we build the EDK2 EfiRom utility > unconditionally. >=20 > Some distributions require to use extra compiler/linker flags, > i.e. SUSE which enforces the PIE protection (see [*]). >=20 > EDK2 build tools already provide a set of variables for that, > use them to allow the caller to easily inject compiler/linker > options.. >=20 > Now build scripts can pass extra options, example: >=20 > $ make -C roms \ > EDK2_BASETOOLS_OPTFLAGS=3D'-fPIE' \ > efirom >=20 > [*] https://lists.opensuse.org/opensuse-factory/2017-06/msg00403.html >=20 > Reported-by: Olaf Hering > Suggested-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > roms/Makefile | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) >=20 > diff --git a/roms/Makefile b/roms/Makefile > index d28252dafdf..1ff78b63bb3 100644 > --- a/roms/Makefile > +++ b/roms/Makefile > @@ -120,8 +120,21 @@ build-efi-roms: build-pxe-roms > $(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \ > $(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets)) > =20 > +# Build scripts can pass compiler/linker flags to the EDK2 build tools > +# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and > +# EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables. > +# > +# Example: > +# > +# make -C roms \ > +# EDK2_BASETOOLS_OPTFLAGS=3D'...' \ > +# EDK2_BASETOOLS_LDFLAGS=3D'...' \ > +# efirom > +# > $(EDK2_EFIROM): > - $(MAKE) -C edk2/BaseTools > + $(MAKE) -C edk2/BaseTools \ > + EXTRA_OPTFLAGS=3D'$(EDK2_BASETOOLS_OPTFLAGS)' \ > + EXTRA_LDFLAGS=3D'$(EDK2_BASETOOLS_LDFLAGS)' > =20 > slof: > $(MAKE) -C SLOF CROSS=3D$(powerpc64_cross_prefix) qemu >=20 Reviewed-by: Laszlo Ersek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49633C282CE for ; Tue, 9 Apr 2019 15:25:50 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EA9720883 for ; Tue, 9 Apr 2019 15:25:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EA9720883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:43316 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDsdB-0006PS-6H for qemu-devel@archiver.kernel.org; Tue, 09 Apr 2019 11:25:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDscP-00061S-Ru for qemu-devel@nongnu.org; Tue, 09 Apr 2019 11:25:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDscO-0006Ab-BF for qemu-devel@nongnu.org; Tue, 09 Apr 2019 11:25:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35948) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDscN-00069l-Uf for qemu-devel@nongnu.org; Tue, 09 Apr 2019 11:25:00 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3637A300C22E; Tue, 9 Apr 2019 15:24:54 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-114.rdu2.redhat.com [10.10.120.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 61A2F19731; Tue, 9 Apr 2019 15:24:44 +0000 (UTC) To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Olaf Hering References: <20190409134536.15548-1-philmd@redhat.com> <20190409134536.15548-3-philmd@redhat.com> From: Laszlo Ersek Message-ID: <8cb9bfab-f213-9dc7-2fb6-96e412ec06ff@redhat.com> Date: Tue, 9 Apr 2019 17:24:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190409134536.15548-3-philmd@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 09 Apr 2019 15:24:56 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH for-4.0 v3 2/2] roms: Allow passing configure options to the EDK2 build tools X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Igor Mammedov , Gerd Hoffmann , "Michael S . Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190409152443.D69-aw1AbZLjblsGk122j1ie-6EZ3bUByWbsbpnkQo0@z> On 04/09/19 15:45, Philippe Mathieu-Daud=C3=A9 wrote: > Since commit f590a812c210 we build the EDK2 EfiRom utility > unconditionally. >=20 > Some distributions require to use extra compiler/linker flags, > i.e. SUSE which enforces the PIE protection (see [*]). >=20 > EDK2 build tools already provide a set of variables for that, > use them to allow the caller to easily inject compiler/linker > options.. >=20 > Now build scripts can pass extra options, example: >=20 > $ make -C roms \ > EDK2_BASETOOLS_OPTFLAGS=3D'-fPIE' \ > efirom >=20 > [*] https://lists.opensuse.org/opensuse-factory/2017-06/msg00403.html >=20 > Reported-by: Olaf Hering > Suggested-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > roms/Makefile | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) >=20 > diff --git a/roms/Makefile b/roms/Makefile > index d28252dafdf..1ff78b63bb3 100644 > --- a/roms/Makefile > +++ b/roms/Makefile > @@ -120,8 +120,21 @@ build-efi-roms: build-pxe-roms > $(patsubst %,bin-i386-efi/%.efidrv,$(pxerom_targets)) \ > $(patsubst %,bin-x86_64-efi/%.efidrv,$(pxerom_targets)) > =20 > +# Build scripts can pass compiler/linker flags to the EDK2 build tools > +# via the EDK2_BASETOOLS_OPTFLAGS (CPPFLAGS and CFLAGS) and > +# EDK2_BASETOOLS_LDFLAGS (LDFLAGS) environment variables. > +# > +# Example: > +# > +# make -C roms \ > +# EDK2_BASETOOLS_OPTFLAGS=3D'...' \ > +# EDK2_BASETOOLS_LDFLAGS=3D'...' \ > +# efirom > +# > $(EDK2_EFIROM): > - $(MAKE) -C edk2/BaseTools > + $(MAKE) -C edk2/BaseTools \ > + EXTRA_OPTFLAGS=3D'$(EDK2_BASETOOLS_OPTFLAGS)' \ > + EXTRA_LDFLAGS=3D'$(EDK2_BASETOOLS_LDFLAGS)' > =20 > slof: > $(MAKE) -C SLOF CROSS=3D$(powerpc64_cross_prefix) qemu >=20 Reviewed-by: Laszlo Ersek