From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10F42C388F9 for ; Tue, 27 Oct 2020 16:42:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8063D206FA for ; Tue, 27 Oct 2020 16:42:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YdaZ9WMp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8063D206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXS3S-00038A-IL for qemu-devel@archiver.kernel.org; Tue, 27 Oct 2020 12:42:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50686) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXRs9-00079I-4I for qemu-devel@nongnu.org; Tue, 27 Oct 2020 12:30:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25410) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kXRs6-0001fO-46 for qemu-devel@nongnu.org; Tue, 27 Oct 2020 12:30:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603816251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jc1g6Z+TmVXwrzIotVpON/VxSUJajRXqlrcdqNovHRc=; b=YdaZ9WMp7z+gHcrdzD0F9DJuqi4e5+7+xBzeHcqThBimf5rSJRg6Ldp9PwFAZUGHK55IPZ JXG9w5qEFr1y+GeD1z8GWrGa553RDmZukV8zinBSk2Vx7RCEE+QtUn5azudXsTsQ3a8YZD pus4cl7TdRLimZrvAD3ty+4FZn0s6eI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-4-RfpLbxPueZBDeu-TgTKw-1; Tue, 27 Oct 2020 12:30:48 -0400 X-MC-Unique: 4-RfpLbxPueZBDeu-TgTKw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 10948809DD9; Tue, 27 Oct 2020 16:30:47 +0000 (UTC) Received: from [10.3.112.145] (ovpn-112-145.phx2.redhat.com [10.3.112.145]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BFF7460C07; Tue, 27 Oct 2020 16:30:46 +0000 (UTC) Subject: Re: [PATCH] osdep.h: Remove include To: Michael Forney , qemu-devel@nongnu.org References: <20201027003848.10920-1-mforney@mforney.org> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <8cc326d8-d3f6-99d2-3843-ed4d78f5efa5@redhat.com> Date: Tue, 27 Oct 2020 11:30:46 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201027003848.10920-1-mforney@mforney.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eblake@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/27 01:06:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.167, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/26/20 7:38 PM, Michael Forney wrote: > Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD > (apart from two .c files). The POSIX standard location for this > header is just and in fact, OpenBSD's signal.h includes > sys/signal.h itself. > > Unconditionally including on musl causes warnings > for just about every source file: > > /usr/include/sys/signal.h:1:2: warning: #warning redirecting incorrect #include to [-Wcpp] > 1 | #warning redirecting incorrect #include to > | ^~~~~~~ > > Since there don't seem to be any platforms which require including > in addition to , and some platforms like > Haiku lack it completely, just remove it. > > Tested building on OpenBSD after removing this include. > > Signed-off-by: Michael Forney > --- > configure | 10 ---------- > include/qemu/osdep.h | 4 ---- > 2 files changed, 14 deletions(-) Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org