From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gX2zc-0002Y7-5T for qemu-devel@nongnu.org; Wed, 12 Dec 2018 06:47:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gX2zX-0002mK-7V for qemu-devel@nongnu.org; Wed, 12 Dec 2018 06:47:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45628) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gX2zW-0002lZ-RG for qemu-devel@nongnu.org; Wed, 12 Dec 2018 06:47:51 -0500 References: <1543851204-41186-1-git-send-email-pbonzini@redhat.com> <1543851204-41186-20-git-send-email-pbonzini@redhat.com> <4e7e0f95-364d-7cdf-67f8-394d1c371870@redhat.com> From: Thomas Huth Message-ID: <8cc60559-42b2-0951-7f99-c459cda4a327@redhat.com> Date: Wed, 12 Dec 2018 12:47:47 +0100 MIME-Version: 1.0 In-Reply-To: <4e7e0f95-364d-7cdf-67f8-394d1c371870@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 19/71] tests: qgraph API for the qtest driver framework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: Emanuele Giuseppe Esposito , Laurent Vivier On 2018-12-12 12:09, Paolo Bonzini wrote: > On 07/12/18 16:38, Thomas Huth wrote: >> I did not do a very detailed review, but from a quick glance, this looks >> quite good to me already (apart from the few minor issues that I've >> mentioned above) >> >> Thomas > > Good, if this is okay for you, my plan is the following: > > - send patches 1-18 in my next pull request to Peter > > - send patches 15-19 for review as v2, for inclusion in your qtest tree > > - once that is done and the patches are included in your tree, send the > more "boring" patches 20-71 directly to you as a pull request, basically > the same as in this submission only with checkpatch fixed. Sounds like a plan, yes. (and yes, I still plan to review the remaining patches, I just did not have enough spare time for that yet ...) Thomas