qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: imammedo@redhat.com, ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 5/9] ivshmem: use ram_from_fd()
Date: Mon, 5 Jun 2017 15:40:52 +0200	[thread overview]
Message-ID: <8cd543c8-fdfa-1ab5-4433-06b3b890eee8@redhat.com> (raw)
In-Reply-To: <20170602141229.15326-6-marcandre.lureau@redhat.com>

On 02/06/2017 16:12, Marc-André Lureau wrote:
> Instead of having its own mmap handling code, reuse the code from
> exec.c.
> 
> Note: memory_region_init_ram_from_fd() adds some restrictions
> (check for xen, kvm sync-mmu, etc) and changes (such as size
> alignment). This may actually be more correct.

I agree.  I'm queuing patches 1-6 for now.

Paolo

  reply	other threads:[~2017-06-05 13:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-02 14:12 [Qemu-devel] [PATCH v3 0/9] Add memfd memory backend Marc-André Lureau
2017-06-02 14:12 ` [Qemu-devel] [PATCH v3 1/9] exec: check kvm mmu notifiers earlier Marc-André Lureau
2017-06-02 14:12 ` [Qemu-devel] [PATCH v3 2/9] exec: split file_ram_alloc() Marc-André Lureau
2017-06-02 14:12 ` [Qemu-devel] [PATCH v3 3/9] exec: split qemu_ram_alloc_from_file() Marc-André Lureau
2017-06-02 17:55   ` Eduardo Habkost
2017-06-02 14:12 ` [Qemu-devel] [PATCH v3 4/9] Add memory_region_init_ram_from_fd() Marc-André Lureau
2017-06-02 14:12 ` [Qemu-devel] [PATCH v3 5/9] ivshmem: use ram_from_fd() Marc-André Lureau
2017-06-05 13:40   ` Paolo Bonzini [this message]
2017-06-02 14:12 ` [Qemu-devel] [PATCH v3 6/9] memory: remove memory_region_set_fd Marc-André Lureau
2017-06-02 14:12 ` [Qemu-devel] [PATCH v3 7/9] memfd: split qemu_memfd_alloc() Marc-André Lureau
2017-06-02 14:12 ` [Qemu-devel] [PATCH v3 8/9] Add memfd based hostmem Marc-André Lureau
2017-06-02 14:12 ` [Qemu-devel] [PATCH v3 9/9] tests: use memfd in vhost-user-test Marc-André Lureau
2017-06-02 14:24 ` [Qemu-devel] [PATCH v3 0/9] Add memfd memory backend Daniel P. Berrange
2017-06-02 14:36   ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8cd543c8-fdfa-1ab5-4433-06b3b890eee8@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).