From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B00DAC0218D for ; Wed, 29 Jan 2025 06:30:04 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1td1a6-0006Se-4Z; Wed, 29 Jan 2025 01:29:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1td1a3-0006Rn-0q for qemu-devel@nongnu.org; Wed, 29 Jan 2025 01:29:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1td1a1-0005rv-A2 for qemu-devel@nongnu.org; Wed, 29 Jan 2025 01:29:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738132178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SMmkyq51R6IOi2GieDY0XZAhY9xJoMRixWw7YbAEFhY=; b=W0iwMc+uEZywun10XP/7Y5mBAwpWR3LhE47iYLEjmU8Z0uds222kiKtKPt0a8iAmXhCKol W5qxLtEKtK7yDcf28mAbW4zkFqdtCPrSGXuncSG3CY3uZ0MrandVecpKlHYXwheIEhtLMl o5Oz4xQpbTnqFBPQqa1HBdMv5frn2pI= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-ZIaxhgEUNp-EV316iwKRrg-1; Wed, 29 Jan 2025 01:29:37 -0500 X-MC-Unique: ZIaxhgEUNp-EV316iwKRrg-1 X-Mimecast-MFC-AGG-ID: ZIaxhgEUNp-EV316iwKRrg Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-ab547c18515so148606966b.2 for ; Tue, 28 Jan 2025 22:29:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738132176; x=1738736976; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SMmkyq51R6IOi2GieDY0XZAhY9xJoMRixWw7YbAEFhY=; b=bcbsGSN4Tyyc69S6hA4sAsloge4R2ac5+9IRsyXAQG7GSGNt77Ac0s0VCZBLnOBtZD x7bOQGWB/axBWSkUlTup+qA9jDliubtJFpiVqWC8+dyY0C0SL7WlUi6JFll0u+7YSJDQ ruAP54W9nuicglbYZN2y6/B9CM9dz3RBnzvdMoOe3C5pbqYykkBIbee/6XiFnNtps/E5 VHYQSG5afTi0upCxVZWMjAY1vPaacr0A6T6leU1gf4G8IrFbZJTDzfCsxaxaX5Ter9p7 MQewzDPehf9rvEsitNZjC93dUqIL1kTEySZmKkt5KjEmOrY+oehXCWxrRhMM2dBCAVDJ EAug== X-Forwarded-Encrypted: i=1; AJvYcCVfnxhXMGmBFK7xe+GhNFq7upRRWzKTIMm7wHmNW/HtLaXdl6T7XXtY/N3EYN/ubY4oQn8vxDe3xOrB@nongnu.org X-Gm-Message-State: AOJu0Yx4t+OWRxew4y+yBNV4aTDk58tz/brVyQRkqQKyne4aF81Rsv+W wFfilpHa5EJAmmSgOQA8p4+mGp4jHP2IELhu5r2WIgdt3TmDr91iCWfc4Qy4cdcLozjRnjVTS7G njpxmBmBu30oRgjLWj68eskU+3zRZjOuY53xPmmHWGchWPEzRywor X-Gm-Gg: ASbGncv2nF9+JxOZntcE/+5v+3zQVkl861GU8iWI4im9Y7kBCyTgnGaeEQ6GOXXcZn9 uF0MucNWH/NQSzFtUtbUhf3ZJKVULdE3Johs9oM/u6uivCvo8qeo9d17y+sC4RXmYE8nK1GYQKq wx0w1EoICb8x7wlze8O/v3DTzDojnDWDQqTkvLj/hcPj6lS3ZOjiWVKcsbdyQ6No/UX5Yqrm9QS czOKGd+0jNBWV2g36KJSJ56rJ0RFftt+/6B3raocYO6jpQruaKeAasdo1VMaMlbY0KCVhLs6RAp 8qemNFkoZzfIKhu/nzik+gGdNnk+fuPvT57s X-Received: by 2002:a17:907:96a1:b0:ab6:8cbb:a91d with SMTP id a640c23a62f3a-ab6cfe27ad3mr169468366b.53.1738132176192; Tue, 28 Jan 2025 22:29:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IFknis4fVNdil1hDAPZt6CdIoOQolvEF1KlBTXNkdChoPkZefReDwgR8WD0sgUh5QX1cYDNzQ== X-Received: by 2002:a17:907:96a1:b0:ab6:8cbb:a91d with SMTP id a640c23a62f3a-ab6cfe27ad3mr169465566b.53.1738132175825; Tue, 28 Jan 2025 22:29:35 -0800 (PST) Received: from [192.168.0.7] (ip-109-42-50-234.web.vodafone.de. [109.42.50.234]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab675e12180sm911186466b.9.2025.01.28.22.29.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2025 22:29:35 -0800 (PST) Message-ID: <8cd67366-c6fa-4a86-8893-af7f2e0982c1@redhat.com> Date: Wed, 29 Jan 2025 07:29:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] virtio-mem-pci: Allow setting nvectors, so we can use MSI-X To: David Hildenbrand , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Eduardo Habkost , Marcel Apfelbaum , Richard Henderson , Ilya Leoshkevich , Halil Pasic , Christian Borntraeger , Eric Farman , "Michael S. Tsirkin" , Cornelia Huck , Boris Fiuczynski , Michal Privoznik , Mario Casquero References: <20250128185705.1609038-1-david@redhat.com> <20250128185705.1609038-2-david@redhat.com> From: Thomas Huth Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20250128185705.1609038-2-david@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.3, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 28/01/2025 19.57, David Hildenbrand wrote: > Let's do it similar as virtio-balloon-pci. With this change, we can > use virtio-mem-pci on s390x, although plugging will still fail until > properly wired up in the machine. > > No need to worry about transitional/non_transitional devices, because they > don't exist for virtio-mem. > > Signed-off-by: David Hildenbrand > --- > hw/core/machine.c | 1 + > hw/virtio/virtio-mem-pci.c | 12 ++++++++++++ > 2 files changed, 13 insertions(+) Reviewed-by: Thomas Huth